Title: [222870] trunk
- Revision
- 222870
- Author
- [email protected]
- Date
- 2017-10-04 12:47:32 -0700 (Wed, 04 Oct 2017)
Log Message
Unreviewed, rolling out r222840.
This change breaks internal builds.
Reverted changeset:
"Generate a compile error if release is built without compiler
optimizations"
https://bugs.webkit.org/show_bug.cgi?id=177665
http://trac.webkit.org/changeset/222840
Modified Paths
Diff
Modified: trunk/CMakeLists.txt (222869 => 222870)
--- trunk/CMakeLists.txt 2017-10-04 19:31:38 UTC (rev 222869)
+++ trunk/CMakeLists.txt 2017-10-04 19:47:32 UTC (rev 222870)
@@ -1,15 +1,4 @@
-# -----------------------------------------------------------------------------
-# Determine CMake version and build type.
-# -----------------------------------------------------------------------------
cmake_minimum_required(VERSION 3.3)
-
-if (NOT CMAKE_BUILD_TYPE)
- message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.")
- set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE)
-else ()
- message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
-endif ()
-
project(WebKit)
set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/Source/cmake")
Modified: trunk/ChangeLog (222869 => 222870)
--- trunk/ChangeLog 2017-10-04 19:31:38 UTC (rev 222869)
+++ trunk/ChangeLog 2017-10-04 19:47:32 UTC (rev 222870)
@@ -1,3 +1,16 @@
+2017-10-04 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r222840.
+
+ This change breaks internal builds.
+
+ Reverted changeset:
+
+ "Generate a compile error if release is built without compiler
+ optimizations"
+ https://bugs.webkit.org/show_bug.cgi?id=177665
+ http://trac.webkit.org/changeset/222840
+
2017-10-04 Commit Queue <[email protected]>
Unreviewed, rolling out r222775.
Modified: trunk/Source/_javascript_Core/ChangeLog (222869 => 222870)
--- trunk/Source/_javascript_Core/ChangeLog 2017-10-04 19:31:38 UTC (rev 222869)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-10-04 19:47:32 UTC (rev 222870)
@@ -1,3 +1,16 @@
+2017-10-04 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r222840.
+
+ This change breaks internal builds.
+
+ Reverted changeset:
+
+ "Generate a compile error if release is built without compiler
+ optimizations"
+ https://bugs.webkit.org/show_bug.cgi?id=177665
+ http://trac.webkit.org/changeset/222840
+
2017-10-04 Carlos Alberto Lopez Perez <[email protected]>
Generate a compile error if release is built without compiler optimizations
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (222869 => 222870)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2017-10-04 19:31:38 UTC (rev 222869)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2017-10-04 19:47:32 UTC (rev 222870)
@@ -344,7 +344,7 @@
0F6183311C45BF070072450B /* AirLowerMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F6183281C45BF070072450B /* AirLowerMacros.h */; };
0F61833C1C45F62A0072450B /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 51F0EB6105C86C6B00E6DF1B /* Foundation.framework */; };
0F61833D1C45F62A0072450B /* _javascript_Core.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 932F5BD90822A1C700736975 /* _javascript_Core.framework */; };
- 0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0 -DRELEASE_WITHOUT_OPTIMIZATIONS"; }; };
+ 0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0"; }; };
0F620174143FCD330068B77C /* DFGVariableAccessData.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F620172143FCD2F0068B77C /* DFGVariableAccessData.h */; };
0F620176143FCD3B0068B77C /* DFGBasicBlock.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F620170143FCD2F0068B77C /* DFGBasicBlock.h */; };
0F620177143FCD3F0068B77C /* DFGAbstractValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F62016F143FCD2F0068B77C /* DFGAbstractValue.h */; };
@@ -636,7 +636,7 @@
0FEC85911BDACDC70080FF74 /* AirValidate.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEC856C1BDACDC70080FF74 /* AirValidate.h */; };
0FEC85A31BDB5CF10080FF74 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 51F0EB6105C86C6B00E6DF1B /* Foundation.framework */; };
0FEC85A41BDB5CF10080FF74 /* _javascript_Core.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 932F5BD90822A1C700736975 /* _javascript_Core.framework */; };
- 0FEC85AF1BDB5D5E0080FF74 /* testb3.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0FEC85AE1BDB5D5E0080FF74 /* testb3.cpp */; settings = {COMPILER_FLAGS = "-O0 -DRELEASE_WITHOUT_OPTIMIZATIONS"; }; };
+ 0FEC85AF1BDB5D5E0080FF74 /* testb3.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0FEC85AE1BDB5D5E0080FF74 /* testb3.cpp */; settings = {COMPILER_FLAGS = "-O0"; }; };
0FEC85B31BDED9570080FF74 /* B3ConstPtrValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEC85B21BDED9570080FF74 /* B3ConstPtrValue.h */; };
0FEC85BA1BE1462F0080FF74 /* B3InsertionSet.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEC85B51BE1462F0080FF74 /* B3InsertionSet.h */; };
0FEC85BB1BE1462F0080FF74 /* B3InsertionSetInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEC85B61BE1462F0080FF74 /* B3InsertionSetInlines.h */; };
Modified: trunk/Source/WTF/ChangeLog (222869 => 222870)
--- trunk/Source/WTF/ChangeLog 2017-10-04 19:31:38 UTC (rev 222869)
+++ trunk/Source/WTF/ChangeLog 2017-10-04 19:47:32 UTC (rev 222870)
@@ -1,3 +1,16 @@
+2017-10-04 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r222840.
+
+ This change breaks internal builds.
+
+ Reverted changeset:
+
+ "Generate a compile error if release is built without compiler
+ optimizations"
+ https://bugs.webkit.org/show_bug.cgi?id=177665
+ http://trac.webkit.org/changeset/222840
+
2017-10-04 Carlos Alberto Lopez Perez <[email protected]>
Generate a compile error if release is built without compiler optimizations
Modified: trunk/Source/WTF/wtf/Compiler.h (222869 => 222870)
--- trunk/Source/WTF/wtf/Compiler.h 2017-10-04 19:31:38 UTC (rev 222869)
+++ trunk/Source/WTF/wtf/Compiler.h 2017-10-04 19:47:32 UTC (rev 222870)
@@ -104,10 +104,6 @@
#endif /* COMPILER(GCC) */
-#if COMPILER(GCC_OR_CLANG) && defined(NDEBUG) && !defined(__OPTIMIZE__) && !defined(RELEASE_WITHOUT_OPTIMIZATIONS)
-#error "Building release without compiler optimizations: WebKit will be slow. Set -DRELEASE_WITHOUT_OPTIMIZATIONS if this is intended."
-#endif
-
/* COMPILER(MINGW) - MinGW GCC */
#if defined(__MINGW32__)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
