Modified: trunk/Source/WebKit/ChangeLog (222879 => 222880)
--- trunk/Source/WebKit/ChangeLog 2017-10-04 20:55:39 UTC (rev 222879)
+++ trunk/Source/WebKit/ChangeLog 2017-10-04 21:15:32 UTC (rev 222880)
@@ -1,3 +1,19 @@
+2017-10-04 David Kilzer <[email protected]>
+
+ Remove unused variables in lambdas for network process cache
+ <https://webkit.org/b/177878>
+ <rdar://problem/34038482>
+
+ Reviewed by Tim Horton.
+
+ * NetworkProcess/cache/CacheStorageEngine.cpp:
+ (WebKit::CacheStorage::Engine::open):
+ (WebKit::CacheStorage::Engine::putRecords):
+ (WebKit::CacheStorage::Engine::deleteMatchingRecords):
+ * NetworkProcess/cache/CacheStorageEngineConnection.cpp:
+ (WebKit::CacheStorageEngineConnection::reference):
+ - Remove unused |this| from lambda captures.
+
2017-10-04 Stephan Szabo <[email protected]>
[WinCairo] add PLATFORM(WIN) configurations to config.h
Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (222879 => 222880)
--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2017-10-04 20:55:39 UTC (rev 222879)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2017-10-04 21:15:32 UTC (rev 222880)
@@ -85,7 +85,7 @@
void Engine::open(const String& origin, const String& cacheName, CacheIdentifierCallback&& callback)
{
- readCachesFromDisk(origin, [this, cacheName, callback = WTFMove(callback)](CachesOrError&& cachesOrError) mutable {
+ readCachesFromDisk(origin, [cacheName, callback = WTFMove(callback)](CachesOrError&& cachesOrError) mutable {
if (!cachesOrError.hasValue()) {
callback(makeUnexpected(cachesOrError.error()));
return;
@@ -138,7 +138,7 @@
void Engine::putRecords(uint64_t cacheIdentifier, Vector<Record>&& records, RecordIdentifiersCallback&& callback)
{
- readCache(cacheIdentifier, [this, records = WTFMove(records), callback = WTFMove(callback)](CacheOrError&& result) mutable {
+ readCache(cacheIdentifier, [records = WTFMove(records), callback = WTFMove(callback)](CacheOrError&& result) mutable {
if (!result.hasValue()) {
callback(makeUnexpected(result.error()));
return;
@@ -150,7 +150,7 @@
void Engine::deleteMatchingRecords(uint64_t cacheIdentifier, WebCore::ResourceRequest&& request, WebCore::CacheQueryOptions&& options, RecordIdentifiersCallback&& callback)
{
- readCache(cacheIdentifier, [this, request = WTFMove(request), options = WTFMove(options), callback = WTFMove(callback)](CacheOrError&& result) mutable {
+ readCache(cacheIdentifier, [request = WTFMove(request), options = WTFMove(options), callback = WTFMove(callback)](CacheOrError&& result) mutable {
if (!result.hasValue()) {
callback(makeUnexpected(result.error()));
return;
Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp (222879 => 222880)
--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp 2017-10-04 20:55:39 UTC (rev 222879)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp 2017-10-04 21:15:32 UTC (rev 222880)
@@ -100,7 +100,7 @@
auto& references = m_cachesLocks.ensure(sessionID, []() {
return HashMap<CacheIdentifier, LockCount> { };
}).iterator->value;
- auto& counter = references.ensure(cacheIdentifier, [this]() {
+ auto& counter = references.ensure(cacheIdentifier, []() {
return 0;
}).iterator->value;
if (!counter++)