Title: [222924] trunk/LayoutTests
- Revision
- 222924
- Author
- [email protected]
- Date
- 2017-10-05 11:57:07 -0700 (Thu, 05 Oct 2017)
Log Message
Layout Test media/modern-media-controls/scrubber-support/scrubber-support-drag.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=174682
Patch by Antoine Quint <[email protected]> on 2017-10-05
Reviewed by Dean Jackson.
This test could fail since we would start it before the time control was fully sized and only
the scrubber had bounds, but not the elapsed time label. We have to wait on both being fully
sized before starting the test and only then it is reliable.
* media/modern-media-controls/scrubber-support/scrubber-support-drag.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (222923 => 222924)
--- trunk/LayoutTests/ChangeLog 2017-10-05 18:51:46 UTC (rev 222923)
+++ trunk/LayoutTests/ChangeLog 2017-10-05 18:57:07 UTC (rev 222924)
@@ -1,5 +1,19 @@
2017-10-05 Antoine Quint <[email protected]>
+ Layout Test media/modern-media-controls/scrubber-support/scrubber-support-drag.html is flaky.
+ https://bugs.webkit.org/show_bug.cgi?id=174682
+
+ Reviewed by Dean Jackson.
+
+ This test could fail since we would start it before the time control was fully sized and only
+ the scrubber had bounds, but not the elapsed time label. We have to wait on both being fully
+ sized before starting the test and only then it is reliable.
+
+ * media/modern-media-controls/scrubber-support/scrubber-support-drag.html:
+ * platform/mac/TestExpectations:
+
+2017-10-05 Antoine Quint <[email protected]>
+
Layout Test media/modern-media-controls/scrubber-support/scrubber-support-click.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=177930
Modified: trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag.html (222923 => 222924)
--- trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag.html 2017-10-05 18:51:46 UTC (rev 222923)
+++ trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag.html 2017-10-05 18:57:07 UTC (rev 222924)
@@ -29,9 +29,10 @@
if (media.paused)
return;
+ const elapsed = mediaController.controls.timeControl.elapsedTimeLabel.element;
const input = mediaController.controls.timeControl.scrubber.children[1].element;
const bounds = input.getBoundingClientRect();
- if (bounds.width === 0)
+ if (elapsed.getBoundingClientRect().width === 0 || bounds.width === 0)
return;
media.pause();
Modified: trunk/LayoutTests/platform/mac/TestExpectations (222923 => 222924)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-10-05 18:51:46 UTC (rev 222923)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-10-05 18:57:07 UTC (rev 222924)
@@ -1571,8 +1571,6 @@
webkit.org/b/173068 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_getKey.html [ Pass Failure ]
-webkit.org/b/174682 media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Pass Failure ]
-
webkit.org/b/175102 workers/wasm-hashset-many.html [ Skip ]
webkit.org/b/175102 workers/wasm-hashset-many-2.html [ Skip ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
