Title: [222928] trunk/Source
- Revision
- 222928
- Author
- [email protected]
- Date
- 2017-10-05 12:12:04 -0700 (Thu, 05 Oct 2017)
Log Message
Bug 177893: Disable -Wcast-qual for new clang compiler in Apple ports
<https://webkit.org/b/177893>
<rdar://problem/33667497>
Reviewed by Tim Horton.
Source/WebCore:
* Configurations/Base.xcconfig:
(WARNING_CFLAGS): Remvoe -Wcast-qual until we can provide a safe
cast function that lets us re-enable the warning.
Source/WTF:
* wtf/RetainPtr.h:
(WTF::RetainPtr::fromStorageType const): Disable warnings for
-Wcast-qual until we can provide a safe cast function that lets
us re-enable the warning.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (222927 => 222928)
--- trunk/Source/WTF/ChangeLog 2017-10-05 19:09:53 UTC (rev 222927)
+++ trunk/Source/WTF/ChangeLog 2017-10-05 19:12:04 UTC (rev 222928)
@@ -1,3 +1,16 @@
+2017-10-05 David Kilzer <[email protected]>
+
+ Bug 177893: Disable -Wcast-qual for new clang compiler in Apple ports
+ <https://webkit.org/b/177893>
+ <rdar://problem/33667497>
+
+ Reviewed by Tim Horton.
+
+ * wtf/RetainPtr.h:
+ (WTF::RetainPtr::fromStorageType const): Disable warnings for
+ -Wcast-qual until we can provide a safe cast function that lets
+ us re-enable the warning.
+
2017-10-05 Matt Lewis <[email protected]>
Unreviewed, rolling out r222893.
Modified: trunk/Source/WTF/wtf/RetainPtr.h (222927 => 222928)
--- trunk/Source/WTF/wtf/RetainPtr.h 2017-10-05 19:09:53 UTC (rev 222927)
+++ trunk/Source/WTF/wtf/RetainPtr.h 2017-10-05 19:12:04 UTC (rev 222928)
@@ -130,7 +130,14 @@
StorageType toStorageType(id ptr) const { return (__bridge StorageType)ptr; }
StorageType toStorageType(CFTypeRef ptr) const { return (StorageType)ptr; }
#else
- PtrType fromStorageType(StorageType ptr) const { return (PtrType)ptr; }
+ PtrType fromStorageType(StorageType ptr) const
+ {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wcast-qual"
+ // FIXME: Bug 177895: Re-enable -Wcast-qual for Apple ports.
+ return (PtrType)ptr;
+#pragma clang diagnostic pop
+ }
StorageType toStorageType(PtrType ptr) const { return (StorageType)ptr; }
#endif
Modified: trunk/Source/WebCore/ChangeLog (222927 => 222928)
--- trunk/Source/WebCore/ChangeLog 2017-10-05 19:09:53 UTC (rev 222927)
+++ trunk/Source/WebCore/ChangeLog 2017-10-05 19:12:04 UTC (rev 222928)
@@ -1,3 +1,15 @@
+2017-10-05 David Kilzer <[email protected]>
+
+ Bug 177893: Disable -Wcast-qual for new clang compiler in Apple ports
+ <https://webkit.org/b/177893>
+ <rdar://problem/33667497>
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+ (WARNING_CFLAGS): Remvoe -Wcast-qual until we can provide a safe
+ cast function that lets us re-enable the warning.
+
2017-10-05 Myles C. Maxfield <[email protected]>
Implement font-display loading behaviors
Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (222927 => 222928)
--- trunk/Source/WebCore/Configurations/Base.xcconfig 2017-10-05 19:09:53 UTC (rev 222927)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2017-10-05 19:12:04 UTC (rev 222928)
@@ -79,7 +79,8 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
-WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wno-unknown-warning-option;
+// FIXME: Bug 177895: Re-enable -Wcast-qual for Apple ports.
+WARNING_CFLAGS = -Wall -Wextra -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wno-unknown-warning-option;
TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
TARGET_MAC_OS_X_VERSION_MAJOR_11 = 101100;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
