Diff
Modified: trunk/Source/WebCore/ChangeLog (100224 => 100225)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 01:43:16 UTC (rev 100225)
@@ -1,3 +1,31 @@
+2011-11-14 Daniel Bates <[email protected]>
+
+ Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
+ https://bugs.webkit.org/show_bug.cgi?id=72335
+
+ Reviewed by Eric Seidel.
+
+ It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
+ in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
+ SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.
+
+ * rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
+ * rendering/svg/RenderSVGContainer.cpp: Ditto.
+ * rendering/svg/RenderSVGForeignObject.cpp: Ditto.
+ * rendering/svg/RenderSVGImage.cpp: Ditto.
+ * rendering/svg/RenderSVGInline.cpp: Ditto.
+ * rendering/svg/RenderSVGModelObject.cpp: Ditto.
+ * rendering/svg/RenderSVGPath.cpp: Ditto.
+ * rendering/svg/RenderSVGResource.cpp: Ditto.
+ * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
+ * rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
+ * rendering/svg/RenderSVGRoot.cpp: Ditto.
+ * rendering/svg/RenderSVGText.cpp: Ditto.
+ * rendering/svg/SVGInlineTextBox.cpp: Ditto.
+ * rendering/svg/SVGRenderSupport.cpp: Ditto.
+ * svg/SVGDocumentExtensions.cpp: Ditto.
+ * svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.
+
2011-11-14 Rafael Weinstein <[email protected]>
[MutationObservers] Add histogram collection for usage of DOM Mutation Events
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -26,6 +26,7 @@
#include "RenderSVGResource.h"
#include "SVGElement.h"
+#include "SVGResourcesCache.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -33,6 +33,7 @@
#include "RenderView.h"
#include "SVGRenderSupport.h"
#include "SVGResources.h"
+#include "SVGResourcesCache.h"
#include "SVGStyledElement.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -30,6 +30,7 @@
#include "RenderView.h"
#include "SVGForeignObjectElement.h"
#include "SVGRenderSupport.h"
+#include "SVGResourcesCache.h"
#include "SVGSVGElement.h"
#include "TransformState.h"
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -43,6 +43,7 @@
#include "SVGPreserveAspectRatio.h"
#include "SVGRenderSupport.h"
#include "SVGResources.h"
+#include "SVGResourcesCache.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -27,6 +27,7 @@
#include "RenderSVGResource.h"
#include "RenderSVGText.h"
#include "SVGInlineFlowBox.h"
+#include "SVGResourcesCache.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -34,6 +34,7 @@
#include "RenderSVGModelObject.h"
#include "RenderSVGResource.h"
+#include "SVGResourcesCache.h"
#include "SVGStyledElement.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -40,6 +40,7 @@
#include "SVGPathData.h"
#include "SVGRenderSupport.h"
#include "SVGResources.h"
+#include "SVGResourcesCache.h"
#include "SVGStyledTransformableElement.h"
#include "SVGTransformList.h"
#include "SVGURIReference.h"
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -28,6 +28,7 @@
#include "RenderSVGResourceContainer.h"
#include "RenderSVGResourceSolidColor.h"
#include "SVGResources.h"
+#include "SVGResourcesCache.h"
#include "SVGURIReference.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -41,6 +41,7 @@
#include "SVGNames.h"
#include "SVGRenderSupport.h"
#include "SVGResources.h"
+#include "SVGResourcesCache.h"
#include "SVGStyledElement.h"
#include "SVGStyledTransformableElement.h"
#include "SVGUnitTypes.h"
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -23,6 +23,7 @@
#include "RenderSVGResourceContainer.h"
#include "RenderSVGShadowTreeRootContainer.h"
+#include "SVGResourcesCache.h"
#include "SVGStyledTransformableElement.h"
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -40,6 +40,7 @@
#include "SVGLength.h"
#include "SVGRenderSupport.h"
#include "SVGResources.h"
+#include "SVGResourcesCache.h"
#include "SVGSVGElement.h"
#include "SVGStyledElement.h"
#include "SVGViewSpec.h"
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -39,6 +39,7 @@
#include "RenderSVGRoot.h"
#include "SVGLengthList.h"
#include "SVGRenderSupport.h"
+#include "SVGResourcesCache.h"
#include "SVGRootInlineBox.h"
#include "SVGTextElement.h"
#include "SVGTextLayoutAttributesBuilder.h"
Modified: trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -34,6 +34,7 @@
#include "RenderSVGResource.h"
#include "RenderSVGResourceSolidColor.h"
#include "SVGImageBufferTools.h"
+#include "SVGResourcesCache.h"
#include "SVGRootInlineBox.h"
#include "SVGTextRunRenderingContext.h"
Modified: trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp (100224 => 100225)
--- trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -39,6 +39,7 @@
#include "RenderSVGResourceMasker.h"
#include "RenderSVGRoot.h"
#include "SVGResources.h"
+#include "SVGResourcesCache.h"
#include "SVGStyledElement.h"
#include "TransformState.h"
#include <wtf/UnusedParam.h>
Modified: trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp (100224 => 100225)
--- trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp 2011-11-15 01:43:16 UTC (rev 100225)
@@ -33,6 +33,7 @@
#include "Page.h"
#include "SMILTimeContainer.h"
#include "SVGElement.h"
+#include "SVGResourcesCache.h"
#include "SVGSMILElement.h"
#include "SVGSVGElement.h"
#include "ScriptableDocumentParser.h"
Modified: trunk/Source/WebCore/svg/SVGDocumentExtensions.h (100224 => 100225)
--- trunk/Source/WebCore/svg/SVGDocumentExtensions.h 2011-11-15 01:39:52 UTC (rev 100224)
+++ trunk/Source/WebCore/svg/SVGDocumentExtensions.h 2011-11-15 01:43:16 UTC (rev 100225)
@@ -22,7 +22,6 @@
#define SVGDocumentExtensions_h
#if ENABLE(SVG)
-#include "SVGResourcesCache.h"
#include <wtf/Forward.h>
#include <wtf/HashMap.h>
#include <wtf/HashSet.h>
@@ -35,9 +34,10 @@
class Document;
class RenderSVGResourceContainer;
class SVGElement;
-class SVGStyledElement;
+class SVGResourcesCache;
class SVGSMILElement;
class SVGSVGElement;
+class SVGStyledElement;
class SVGDocumentExtensions {
WTF_MAKE_NONCOPYABLE(SVGDocumentExtensions); WTF_MAKE_FAST_ALLOCATED;
