Title: [222988] trunk/Source/WebInspectorUI
- Revision
- 222988
- Author
- [email protected]
- Date
- 2017-10-06 11:03:17 -0700 (Fri, 06 Oct 2017)
Log Message
Web Inspector: Network Tab - Make selection in the table more reliable (mousedown instead of click)
https://bugs.webkit.org/show_bug.cgi?id=177990
Patch by Joseph Pecoraro <[email protected]> on 2017-10-06
Reviewed by Brian Burg.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.tableCellClicked): Deleted.
* UserInterface/Views/Table.js:
(WI.Table.prototype._handleMouseDown):
(WI.Table.prototype._handleClick): Deleted.
Switch to mousedown.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (222987 => 222988)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-06 16:59:41 UTC (rev 222987)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-06 18:03:17 UTC (rev 222988)
@@ -1,5 +1,19 @@
2017-10-06 Joseph Pecoraro <[email protected]>
+ Web Inspector: Network Tab - Make selection in the table more reliable (mousedown instead of click)
+ https://bugs.webkit.org/show_bug.cgi?id=177990
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype.tableCellClicked): Deleted.
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype._handleMouseDown):
+ (WI.Table.prototype._handleClick): Deleted.
+ Switch to mousedown.
+
+2017-10-06 Joseph Pecoraro <[email protected]>
+
Web Inspector: Improve setting the default / initial sort of a Table
https://bugs.webkit.org/show_bug.cgi?id=177989
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (222987 => 222988)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-10-06 16:59:41 UTC (rev 222987)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-10-06 18:03:17 UTC (rev 222988)
@@ -226,7 +226,7 @@
// Table delegate
- tableCellClicked(table, cell, column, rowIndex, event)
+ tableCellMouseDown(table, cell, column, rowIndex, event)
{
if (column !== this._nameColumn)
return;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (222987 => 222988)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2017-10-06 16:59:41 UTC (rev 222987)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2017-10-06 18:03:17 UTC (rev 222988)
@@ -56,8 +56,8 @@
this._scrollContainerElement.className = "data-container";
this._scrollContainerElement.addEventListener("scroll", scrollHandler);
this._scrollContainerElement.addEventListener("mousewheel", scrollHandler);
- if (this._delegate.tableCellClicked)
- this._scrollContainerElement.addEventListener("click", this._handleClick.bind(this));
+ if (this._delegate.tableCellMouseDown)
+ this._scrollContainerElement.addEventListener("mousedown", this._handleMouseDown.bind(this));
if (this._delegate.tableCellContextMenuClicked)
this._scrollContainerElement.addEventListener("contextmenu", this._handleContextMenu.bind(this));
@@ -1100,8 +1100,11 @@
}
}
- _handleClick(event)
+ _handleMouseDown(event)
{
+ if (event.button !== 0 || event.ctrlKey)
+ return;
+
let cell = event.target.enclosingNodeOrSelfWithClass("cell");
if (!cell)
return;
@@ -1114,7 +1117,7 @@
let column = this._visibleColumns[columnIndex];
let rowIndex = row.__index;
- this._delegate.tableCellClicked(this, cell, column, rowIndex, event);
+ this._delegate.tableCellMouseDown(this, cell, column, rowIndex, event);
}
_handleContextMenu(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
