Title: [223030] trunk/Source/WebKit
Revision
223030
Author
[email protected]
Date
2017-10-08 01:00:41 -0700 (Sun, 08 Oct 2017)

Log Message

mediaPlaybackRequiresUserAction API replacement annotation is wrong
https://bugs.webkit.org/show_bug.cgi?id=178063

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebViewConfiguration.h:
mediaPlaybackRequiresUserAction suggests that you should use
requiresUserActionForMediaPlayback instead, but that is also deprecated.
Instead, follow the chain and suggest mediaTypesRequiringUserActionForPlayback.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (223029 => 223030)


--- trunk/Source/WebKit/ChangeLog	2017-10-08 07:52:14 UTC (rev 223029)
+++ trunk/Source/WebKit/ChangeLog	2017-10-08 08:00:41 UTC (rev 223030)
@@ -1,3 +1,15 @@
+2017-10-08  Tim Horton  <[email protected]>
+
+        mediaPlaybackRequiresUserAction API replacement annotation is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=178063
+
+        Reviewed by Dan Bernstein.
+
+        * UIProcess/API/Cocoa/WKWebViewConfiguration.h:
+        mediaPlaybackRequiresUserAction suggests that you should use 
+        requiresUserActionForMediaPlayback instead, but that is also deprecated.
+        Instead, follow the chain and suggest mediaTypesRequiringUserActionForPlayback.
+
 2017-10-06  Wenson Hsieh  <[email protected]>
 
         [iOS WK2] API tests added in r222991 are failing in iOS 11 test runners

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h (223029 => 223030)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h	2017-10-08 07:52:14 UTC (rev 223029)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h	2017-10-08 08:00:41 UTC (rev 223030)
@@ -200,7 +200,7 @@
 @interface WKWebViewConfiguration (WKDeprecated)
 
 #if TARGET_OS_IPHONE
-@property (nonatomic) BOOL mediaPlaybackRequiresUserAction WK_API_DEPRECATED_WITH_REPLACEMENT("requiresUserActionForMediaPlayback", ios(8.0, 9.0));
+@property (nonatomic) BOOL mediaPlaybackRequiresUserAction WK_API_DEPRECATED_WITH_REPLACEMENT("mediaTypesRequiringUserActionForPlayback", ios(8.0, 9.0));
 @property (nonatomic) BOOL mediaPlaybackAllowsAirPlay WK_API_DEPRECATED_WITH_REPLACEMENT("allowsAirPlayForMediaPlayback", ios(8.0, 9.0));
 @property (nonatomic) BOOL requiresUserActionForMediaPlayback WK_API_DEPRECATED_WITH_REPLACEMENT("mediaTypesRequiringUserActionForPlayback", ios(9.0, 10.0));
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to