Title: [223078] trunk/Source/WebInspectorUI
- Revision
- 223078
- Author
- [email protected]
- Date
- 2017-10-09 15:47:58 -0700 (Mon, 09 Oct 2017)
Log Message
Web Inspector: Network Tab - Include remote address in the Headers view
https://bugs.webkit.org/show_bug.cgi?id=178094
<rdar://problem/34895221>
Patch by Joseph Pecoraro <[email protected]> on 2017-10-09
Reviewed by Devin Rousso.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
(WI.ResourceHeadersContentView.prototype._resourceMetricsDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (223077 => 223078)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-09 22:44:55 UTC (rev 223077)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-09 22:47:58 UTC (rev 223078)
@@ -1,5 +1,18 @@
2017-10-09 Joseph Pecoraro <[email protected]>
+ Web Inspector: Network Tab - Include remote address in the Headers view
+ https://bugs.webkit.org/show_bug.cgi?id=178094
+ <rdar://problem/34895221>
+
+ Reviewed by Devin Rousso.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/ResourceHeadersContentView.js:
+ (WI.ResourceHeadersContentView.prototype._refreshSummarySection):
+ (WI.ResourceHeadersContentView.prototype._resourceMetricsDidChange):
+
+2017-10-09 Joseph Pecoraro <[email protected]>
+
Unreviewed, minified WebInspector opens blank.
<rdar://problem/34892307>
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (223077 => 223078)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-10-09 22:44:55 UTC (rev 223077)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-10-09 22:47:58 UTC (rev 223078)
@@ -78,6 +78,7 @@
localizedStrings["Add probe _expression_"] = "Add probe _expression_";
localizedStrings["Add watch _expression_"] = "Add watch _expression_";
localizedStrings["Additions"] = "Additions";
+localizedStrings["Address"] = "Address";
localizedStrings["Align"] = "Align";
localizedStrings["Alignment"] = "Alignment";
localizedStrings["All"] = "All";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js (223077 => 223078)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js 2017-10-09 22:44:55 UTC (rev 223077)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js 2017-10-09 22:47:58 UTC (rev 223078)
@@ -272,6 +272,9 @@
let source = this._responseSourceDisplayString(this._resource.responseSource) || emDash;
this._appendKeyValuePair(detailsElement, WI.UIString("Source"), source);
+
+ if (this._resource.remoteAddress)
+ this._appendKeyValuePair(detailsElement, WI.UIString("Address"), this._resource.remoteAddress);
}
_refreshRequestHeadersSection()
@@ -407,13 +410,6 @@
this._appendKeyValuePair(detailsElement, WI.UIString("Request Data"), goToButton);
}
- _resourceMetricsDidChange(event)
- {
- this._needsRequestHeadersRefresh = true;
- this._needsResponseHeadersRefresh = true;
- this.needsLayout();
- }
-
_perfomSearchOnKeyValuePairs()
{
let searchRegex = new RegExp(this._searchQuery.escapeForRegExp(), "gi");
@@ -465,6 +461,14 @@
this.element.appendChild(this._bouncyHighlightElement);
}
+ _resourceMetricsDidChange(event)
+ {
+ this._needsSummaryRefresh = true;
+ this._needsRequestHeadersRefresh = true;
+ this._needsResponseHeadersRefresh = true;
+ this.needsLayout();
+ }
+
_resourceRequestHeadersDidChange(event)
{
this._needsRequestHeadersRefresh = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
