Title: [223111] trunk/Source/WTF
Revision
223111
Author
[email protected]
Date
2017-10-09 18:20:34 -0700 (Mon, 09 Oct 2017)

Log Message

Disable INPUT_TYPE_COLOR in FeatureDefines.h
https://bugs.webkit.org/show_bug.cgi?id=178103
<rdar://problem/34872127>

Reviewed by Simon Fraser.

* wtf/FeatureDefines.h:
Because FeatureDefines.h overrides features that are not enabled in
FeatureDefines.xcconfig, you currently have to turn INPUT_TYPE_COLOR
off in two places. Since we only ever want it on for Mac, it's OK
to depend on the xcconfig defining it.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (223110 => 223111)


--- trunk/Source/WTF/ChangeLog	2017-10-10 01:15:42 UTC (rev 223110)
+++ trunk/Source/WTF/ChangeLog	2017-10-10 01:20:34 UTC (rev 223111)
@@ -1,3 +1,17 @@
+2017-10-09  Tim Horton  <[email protected]>
+
+        Disable INPUT_TYPE_COLOR in FeatureDefines.h
+        https://bugs.webkit.org/show_bug.cgi?id=178103
+        <rdar://problem/34872127>
+
+        Reviewed by Simon Fraser.
+
+        * wtf/FeatureDefines.h:
+        Because FeatureDefines.h overrides features that are not enabled in
+        FeatureDefines.xcconfig, you currently have to turn INPUT_TYPE_COLOR
+        off in two places. Since we only ever want it on for Mac, it's OK
+        to depend on the xcconfig defining it.
+
 2017-10-09  Sam Weinig  <[email protected]>
 
         Make HashMap::keys() and HashMap::values() work with WTF::map/WTF::copyToVector

Modified: trunk/Source/WTF/wtf/FeatureDefines.h (223110 => 223111)


--- trunk/Source/WTF/wtf/FeatureDefines.h	2017-10-10 01:15:42 UTC (rev 223110)
+++ trunk/Source/WTF/wtf/FeatureDefines.h	2017-10-10 01:20:34 UTC (rev 223111)
@@ -211,14 +211,6 @@
 #define ENABLE_CURSOR_VISIBILITY 1
 #endif
 
-#if !defined(ENABLE_INPUT_TYPE_COLOR)
-#define ENABLE_INPUT_TYPE_COLOR 1
-#endif
-
-#if !defined(ENABLE_INPUT_TYPE_COLOR_POPOVER)
-#define ENABLE_INPUT_TYPE_COLOR_POPOVER 1
-#endif
-
 #if !defined(ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC)
 #define ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC 1
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to