Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (223136 => 223137)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-10 19:24:03 UTC (rev 223137)
@@ -1,3 +1,29 @@
+2017-10-10 Ross Kirsling <ross.kirsl...@sony.com>
+
+ Web Inspector: Views should explicitly remove event listeners from managers/Frame
+ https://bugs.webkit.org/show_bug.cgi?id=175951
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
+ (WI.ApplicationCacheDetailsSidebarPanel.prototype.closed):
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+ (WI.DOMNodeDetailsSidebarPanel.prototype.closed):
+ * UserInterface/Views/DebuggerDashboardView.js:
+ (WI.DebuggerDashboardView.prototype.closed):
+ * UserInterface/Views/LogContentView.js:
+ (WI.LogContentView.prototype.closed):
+ * UserInterface/Views/NetworkGridContentView.js:
+ (WI.NetworkGridContentView.prototype.closed):
+ * UserInterface/Views/ProbeDetailsSidebarPanel.js:
+ (WI.ProbeDetailsSidebarPanel.prototype.closed):
+ * UserInterface/Views/QuickConsole.js:
+ (WI.QuickConsole.prototype.closed):
+ * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
+ (WI.ScopeChainDetailsSidebarPanel.prototype.closed):
+ * UserInterface/Views/TimelineOverview.js:
+ (WI.TimelineOverview.prototype.closed):
+
2017-10-09 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Network Tab - Include remote address in the Headers view
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -72,6 +72,13 @@
this.needsLayout();
}
+ closed()
+ {
+ WI.applicationCacheManager.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
// Protected
initialLayout()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -38,6 +38,13 @@
// Public
+ closed()
+ {
+ WI.domTreeManager.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
addEventListeners()
{
this.domNode.addEventListener(WI.DOMNode.Event.EventListenersChanged, this._eventListenersChanged, this);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -56,6 +56,15 @@
this._rebuildLocation();
}
+ // Public
+
+ closed()
+ {
+ WI.debuggerManager.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
// Private
_rebuildLocation()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -142,6 +142,14 @@
this._logViewController.renderPendingMessages();
}
+ closed()
+ {
+ WI.logManager.removeEventListener(null, null, this);
+ WI.Frame.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
didAppendConsoleMessageView(messageView)
{
console.assert(messageView instanceof WI.ConsoleMessageView || messageView instanceof WI.ConsoleCommandView);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -209,6 +209,8 @@
super.closed();
this._dataGrid.closed();
+
+ WI.Frame.removeEventListener(null, null, this);
}
reset()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -84,6 +84,13 @@
return !!this._inspectedProbeSets.length;
}
+ closed()
+ {
+ WI.probeManager.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
// Protected
initialLayout()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -98,6 +98,18 @@
WI.runtimeManager.activeExecutionContext = executionContext;
}
+ closed()
+ {
+ WI.Frame.removeEventListener(null, null, this);
+ WI.debuggerManager.removeEventListener(null, null, this);
+ WI.runtimeManager.removeEventListener(null, null, this);
+ WI.targetManager.removeEventListener(null, null, this);
+ WI.consoleDrawer.removeEventListener(null, null, this);
+ WI.TabBrowser.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
// Protected
layout()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -111,6 +111,15 @@
this.needsLayout();
}
+ closed()
+ {
+ WI.runtimeManager.removeEventListener(null, null, this);
+ WI.Frame.removeEventListener(null, null, this);
+ WI.debuggerManager.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
// Protected
layout()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (223136 => 223137)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2017-10-10 19:09:51 UTC (rev 223136)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2017-10-10 19:24:03 UTC (rev 223137)
@@ -362,6 +362,13 @@
overviewGraph.hidden();
}
+ closed()
+ {
+ WI.timelineManager.removeEventListener(null, null, this);
+
+ super.closed();
+ }
+
reset()
{
for (let overviewGraph of this._overviewGraphsByTypeMap.values())
