Diff
Modified: trunk/LayoutTests/ChangeLog (223175 => 223176)
--- trunk/LayoutTests/ChangeLog 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/ChangeLog 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,3 +1,43 @@
+2017-10-11 Antoine Quint <[email protected]>
+
+ Rebaseline tests at media/modern-media-controls/media-controller
+ https://bugs.webkit.org/show_bug.cgi?id=178129
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline a series of tests to work with the current modern-media-controls codebase. For the most part, this is accounting
+ for metrics changes and the refactoring of the auto-hide controller code.
+
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
+ * media/modern-media-controls/media-controller/media-controller-auto-hide.html:
+ * media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html:
+ * media/modern-media-controls/media-controller/media-controller-compact-expected.txt: Removed.
+ * media/modern-media-controls/media-controller/media-controller-compact.html: Removed.
+ * media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
+ * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
+ * media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html:
+ * media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html:
+ * media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-scale-factor.html:
+ * media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt: Removed.
+ * media/modern-media-controls/media-controller/media-controller-tight-padding.html: Removed.
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac-elcapitan/TestExpectations:
+ * platform/mac/TestExpectations:
+
2017-09-27 Frederic Wang <[email protected]>
[iOS] Do not flatten frames when async frame scrolling is enabled
Copied: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt (from rev 223175, trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt) (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,11 @@
+Testing that tapping on the skip back button while playing on iOS does not fade the controls.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width became different from 0
+PASS window.internals.shadowRoot(media).querySelector('.media-controls').classList.contains('faded') is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button.html (from rev 223175, trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html) (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,27 @@
+<script src=""
+<script src="" type="text/_javascript_"></script>
+<meta name="viewport" content="width=device-width, initial-scale=1">
+<body>
+<video src="" style="width: 800px; position: absolute; left: 0; top: 0;" type="video/mp4" playsinline muted autoplay controls></video>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing that tapping on the skip back button while playing on iOS does not fade the controls.");
+
+const media = document.querySelector("video");
+
+media.addEventListener("play", event => {
+ shouldBecomeDifferent("window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width", "0", () => {
+ pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
+ window.requestAnimationFrame(() => {
+ shouldBeFalse("window.internals.shadowRoot(media).querySelector('.media-controls').classList.contains('faded')");
+ finishJSTest();
+ });
+ });
+ });
+});
+
+</script>
+<script src=""
+</body>
Added: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,22 @@
+Testing the MediaController controls bar tap gesture recognizer is only enabled when fadesWhileIdle is true.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Default state
+PASS autoHideController.fadesWhileIdle is false
+PASS autoHideController._tapGestureRecognizer.enabled is false
+
+autoHideController.fadesWhileIdle = true
+PASS autoHideController.fadesWhileIdle is true
+PASS autoHideController._tapGestureRecognizer.enabled is true
+
+autoHideController.fadesWhileIdle = false
+PASS autoHideController.fadesWhileIdle is false
+PASS autoHideController._tapGestureRecognizer.enabled is false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+
Added: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,35 @@
+<script src=""
+<script src="" type="text/_javascript_"></script>
+<body>
+<audio src="" controls style="width: 300px; pointer-events: none; opacity: 0;"></audio>
+<div id="shadow" style="width: 300px; height: 50px;"></div>
+<script type="text/_javascript_">
+
+description("Testing the <code>MediaController</code> controls bar tap gesture recognizer is only enabled when fadesWhileIdle is true.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("audio");
+const mediaController = createControls(shadowRoot, media, null);
+const autoHideController = mediaController.controls.autoHideController;
+
+debug("Default state");
+shouldBeFalse("autoHideController.fadesWhileIdle");
+shouldBeFalse("autoHideController._tapGestureRecognizer.enabled");
+
+autoHideController.fadesWhileIdle = true;
+debug("");
+debug("autoHideController.fadesWhileIdle = true")
+shouldBeTrue("autoHideController.fadesWhileIdle");
+shouldBeTrue("autoHideController._tapGestureRecognizer.enabled");
+
+autoHideController.fadesWhileIdle = false;
+debug("");
+debug("autoHideController.fadesWhileIdle = false")
+shouldBeFalse("autoHideController.fadesWhileIdle");
+shouldBeFalse("autoHideController._tapGestureRecognizer.enabled");
+
+debug("");
+
+</script>
+<script src=""
+</body>
Copied: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio-expected.txt (from rev 223175, trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt) (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,14 @@
+Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS for audio and also center the controls vertically.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS shadowRoot.querySelector('.media-controls').style.width is "800px"
+PASS shadowRoot.querySelector('.media-controls').style.height is "62px"
+PASS shadowRoot.querySelector('.media-controls').style.transform is "scale(0.5)"
+PASS shadowRoot.querySelector('.media-controls').style.top is "-15.5px"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio.html (from rev 223175, trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html) (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<script src=""
+<meta name="viewport" content="width=400">
+<body>
+<audio src="" style="position: absolute; top: 100px; left: 0; width: 400px;" controls></audio>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS for audio and also center the controls vertically.");
+
+const media = document.querySelector("audio");
+const shadowRoot = window.internals.shadowRoot(media);
+
+window.requestAnimationFrame(() => {
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.width", "800px");
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.height", "62px");
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.transform", "scale(0.5)");
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.top", "-15.5px");
+
+ debug("");
+ media.remove();
+ finishJSTest();
+});
+
+</script>
+<script src=""
+</body>
Copied: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-expected.txt (from rev 223175, trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt) (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,14 @@
+Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS shadowRoot.querySelector('.media-controls').style.width is "800px"
+PASS shadowRoot.querySelector('.media-controls').style.height is "600px"
+PASS shadowRoot.querySelector('.media-controls').style.transform is "scale(0.5)"
+PASS shadowRoot.querySelector('.media-controls').style.top is "auto"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor.html (from rev 223175, trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor.html) (0 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<script src=""
+<meta name="viewport" content="width=400">
+<body>
+<video src="" style="position: absolute; top: 0; left: 0; width: 400px; height: 300px;" controls></video>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS.");
+
+const media = document.querySelector("video");
+const shadowRoot = window.internals.shadowRoot(media);
+
+window.requestAnimationFrame(() => {
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.width", "800px");
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.height", "600px");
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.transform", "scale(0.5)");
+ shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.top", "auto");
+
+ debug("");
+ media.remove();
+ finishJSTest();
+});
+
+</script>
+<script src=""
+</body>
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -3,9 +3,9 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS !!shadowRoot.querySelector('.controls-bar') became true
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
+PASS !!shadowRoot.querySelector('.media-controls') became true
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -3,19 +3,19 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS !!shadowRoot.querySelector('.controls-bar') became true
+PASS !!shadowRoot.querySelector('.media-controls') became true
Video started playing, controls bar should become visible by default.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
Controls bar should become faded when the auto-hide timer elapses.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
Mouse moved over the media, controls bar should become visible again.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
Mouse moved out of the media, controls bar should become faded.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -12,21 +12,21 @@
const shadowRoot = window.internals.shadowRoot(media);
media.addEventListener("play", (event) => {
- shouldBecomeEqual("!!shadowRoot.querySelector('.controls-bar')", "true", () => {
+ shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
debug("");
debug("Video started playing, controls bar should become visible by default.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
debug("");
debug("Controls bar should become faded when the auto-hide timer elapses.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
eventSender.mouseMoveTo(100, 100);
debug("");
debug("Mouse moved over the media, controls bar should become visible again.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
eventSender.mouseMoveTo(400, 400);
debug("");
debug("Mouse moved out of the media, controls bar should become faded.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
debug("");
media.remove();
finishJSTest();
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -4,16 +4,16 @@
Video started playing, controls bar is visible by default.
-PASS controlsBar.classList.contains('faded') is false
+PASS mediaControls.classList.contains('faded') is false
Auto-hide timer has elapsed, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
+PASS mediaControls.classList.contains('faded') is true
Mouse moved over the media, controls bar should be visible.
-PASS controlsBar.classList.contains('faded') is false
+PASS mediaControls.classList.contains('faded') is false
Auto-hide timer would have elapsed, but the controls bar remains visible since the mouse is over the controls bar.
-PASS controlsBar.classList.contains('faded') is false
+PASS mediaControls.classList.contains('faded') is false
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -4,7 +4,7 @@
Video started playing, controls bar is visible by default.
-PASS controlsBar.classList.contains('faded') is false
+PASS mediaControls.classList.contains('faded') is false
Pausing media.
Media playback has paused, this stops the auto-hide timer.
@@ -17,10 +17,10 @@
Mouse leaving the media.
The initial auto-hide timer started when we resumed playback should not have expired or be overriden by the mouse entering and leaving the media, the controls should remain visible.
-PASS controlsBar.classList.contains('faded') is false
+PASS mediaControls.classList.contains('faded') is false
The initial auto-hide timer started when we resumed playback should now have expired and the controls should be faded.
-PASS controlsBar.classList.contains('faded') is true
+PASS mediaControls.classList.contains('faded') is true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -8,7 +8,7 @@
description("Testing the controls bar appears when the mouse enters and disappears when the mouse leaves the media.");
-let controlsBar;
+let mediaControls;
const media = document.querySelector("video");
media.addEventListener("play", mediaStartedPlaying);
@@ -17,12 +17,12 @@
{
media.removeEventListener("play", mediaStartedPlaying);
baseTime = Date.now();
- controlsBar = window.internals.shadowRoot(media).querySelector(".controls-bar");
+ mediaControls = window.internals.shadowRoot(media).querySelector(".media-controls");
window.requestAnimationFrame(() => {
debug("Video started playing, controls bar is visible by default.");
- shouldBeFalse("controlsBar.classList.contains('faded')");
+ shouldBeFalse("mediaControls.classList.contains('faded')");
debug("");
debug("Pausing media.");
@@ -57,7 +57,7 @@
window.requestAnimationFrame(() => {
debug("");
debug("The initial auto-hide timer started when we resumed playback should not have expired or be overriden by the mouse entering and leaving the media, the controls should remain visible.");
- shouldBeFalse("controlsBar.classList.contains('faded')");
+ shouldBeFalse("mediaControls.classList.contains('faded')");
});
}, 50);
}, 50);
@@ -65,7 +65,7 @@
setTimeout(() => {
debug("");
debug("The initial auto-hide timer started when we resumed playback should now have expired and the controls should be faded.");
- shouldBeTrue("controlsBar.classList.contains('faded')");
+ shouldBeTrue("mediaControls.classList.contains('faded')");
debug("");
media.remove();
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -4,10 +4,10 @@
Video started playing, controls bar is visible by default.
-PASS controlsBar.classList.contains('faded') is false
+PASS mediaControls.classList.contains('faded') is false
Auto-hide timer would have elapsed, but media was paused so controls bar should remain visible.
-PASS controlsBar.classList.contains('faded') is false
+PASS mediaControls.classList.contains('faded') is false
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -8,15 +8,15 @@
description("Testing the controls bar remains visible when the media is paused.");
-let controlsBar;
+let mediaControls;
document.querySelector("video").addEventListener("play", event => {
window.requestAnimationFrame(() => {
const media = event.target;
- controlsBar = window.internals.shadowRoot(media).querySelector(".controls-bar");
+ mediaControls = window.internals.shadowRoot(media).querySelector(".media-controls");
debug("Video started playing, controls bar is visible by default.");
- shouldBeFalse("controlsBar.classList.contains('faded')");
+ shouldBeFalse("mediaControls.classList.contains('faded')");
media.pause();
media.addEventListener("pause", event => {
@@ -23,7 +23,7 @@
setTimeout(() => {
debug("");
debug("Auto-hide timer would have elapsed, but media was paused so controls bar should remain visible.");
- shouldBeFalse("controlsBar.classList.contains('faded')");
+ shouldBeFalse("mediaControls.classList.contains('faded')");
debug("");
media.remove();
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -3,19 +3,19 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS !!shadowRoot.querySelector('.controls-bar') became true
+PASS !!shadowRoot.querySelector('.media-controls') became true
Video started playing, controls bar should become visible by default.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
Controls bar should fade when the auto-hide timer has elapsed.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
Mouse moved over the media, controls bar should become visible.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
Controls bar should fade when the auto-hide timer has elapsed.
-PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
+PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -12,20 +12,20 @@
const shadowRoot = window.internals.shadowRoot(media);
media.addEventListener("play", (event) => {
- shouldBecomeEqual("!!shadowRoot.querySelector('.controls-bar')", "true", () => {
+ shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
debug("");
debug("Video started playing, controls bar should become visible by default.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
debug("");
debug("Controls bar should fade when the auto-hide timer has elapsed.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
eventSender.mouseMoveTo(100, 100);
debug("");
debug("Mouse moved over the media, controls bar should become visible.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
debug("");
debug("Controls bar should fade when the auto-hide timer has elapsed.");
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
debug("");
media.remove();
finishJSTest();
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -12,9 +12,9 @@
const shadowRoot = window.internals.shadowRoot(media);
media.addEventListener("play", (event) => {
- shouldBecomeEqual("!!shadowRoot.querySelector('.controls-bar')", "true", () => {
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
- shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
+ shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
+ shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
debug("");
media.remove();
finishJSTest();
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -16,7 +16,7 @@
const bounds = media.getBoundingClientRect();
debug("");
debug("Clicking on video controls");
- eventSender.mouseMoveTo(bounds.left + 5, bounds.bottom - 5);
+ eventSender.mouseMoveTo(bounds.left + 10, bounds.bottom - 10);
eventSender.mouseDown();
eventSender.mouseUp();
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-compact-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-compact-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-compact-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,10 +0,0 @@
-Testing the MediaController sizing behavior with compact mode.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS !!(mediaController.controls.layoutTraits & LayoutTraits.Compact) became true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-compact.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-compact.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-compact.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,31 +0,0 @@
-<script src=""
-<script src="" type="text/_javascript_"></script>
-<style type="text/css" media="screen">
-
- video, #shadow {
- position: absolute;
- left: 0;
- top: 0;
- width: 800px;
- height: 600px;
- }
-
-</style>
-<body>
-<video src="" controls autoplay></video>
-<div id="shadow"></div>
-<script type="text/_javascript_">
-
-window.jsTestIsAsync = true;
-
-description("Testing the <code>MediaController</code> sizing behavior with compact mode.");
-
-const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
-const media = document.querySelector("video");
-const mediaController = createControls(shadowRoot, media, null);
-
-shouldBecomeEqual("!!(mediaController.controls.layoutTraits & LayoutTraits.Compact)", "true", finishJSTest);
-
-</script>
-<script src=""
-</body>
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -8,7 +8,7 @@
PASS mediaController.controls instanceof MacOSFullscreenMediaControls is true
Media exited fullscreen
-PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Compact
+PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Inline
PASS mediaController.controls instanceof MacOSInlineMediaControls is true
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -14,6 +14,7 @@
const mediaController = createControls(shadowRoot, media, null);
const button = document.body.appendChild(document.createElement("button"));
+button.textContent = "Enter Fullscreen";
function enterFullscreen()
{
@@ -46,7 +47,7 @@
media.webkitExitFullscreen()
} else {
debug("Media exited fullscreen");
- shouldBe("mediaController.layoutTraits", "LayoutTraits.macOS | LayoutTraits.Compact");
+ shouldBe("mediaController.layoutTraits", "LayoutTraits.macOS | LayoutTraits.Inline");
shouldBeTrue("mediaController.controls instanceof MacOSInlineMediaControls");
debug("");
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,11 +0,0 @@
-Testing that tapping on the skip back button while playing on iOS does not fade the controls.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width became different from 0
-PASS window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded') is false
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,27 +0,0 @@
-<script src=""
-<script src="" type="text/_javascript_"></script>
-<meta name="viewport" content="width=device-width, initial-scale=1">
-<body>
-<video src="" style="width: 300px; position: absolute; left: 0; top: 0;" type="video/mp4" playsinline muted autoplay controls></video>
-<script type="text/_javascript_">
-
-window.jsTestIsAsync = true;
-
-description("Testing that tapping on the skip back button while playing on iOS does not fade the controls.");
-
-const media = document.querySelector("video");
-
-media.addEventListener("play", event => {
- shouldBecomeDifferent("window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width", "0", () => {
- pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
- window.requestAnimationFrame(() => {
- shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
- finishJSTest();
- });
- });
- });
-});
-
-</script>
-<script src=""
-</body>
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,22 +0,0 @@
-Testing the MediaController controls bar tap gesture recognizer is only enabled when fadesWhileIdle is true.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Default state
-PASS controlsBar.fadesWhileIdle is false
-PASS controlsBar._tapGestureRecognizer.enabled is false
-
-controlsBar.fadesWhileIdle = true
-PASS controlsBar.fadesWhileIdle is true
-PASS controlsBar._tapGestureRecognizer.enabled is true
-
-controlsBar.fadesWhileIdle = false
-PASS controlsBar.fadesWhileIdle is false
-PASS controlsBar._tapGestureRecognizer.enabled is false
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
-
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,35 +0,0 @@
-<script src=""
-<script src="" type="text/_javascript_"></script>
-<body>
-<audio src="" controls style="width: 300px; pointer-events: none; opacity: 0;"></audio>
-<div id="shadow" style="width: 300px; height: 50px;"></div>
-<script type="text/_javascript_">
-
-description("Testing the <code>MediaController</code> controls bar tap gesture recognizer is only enabled when fadesWhileIdle is true.");
-
-const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
-const media = document.querySelector("audio");
-const mediaController = createControls(shadowRoot, media, null);
-const controlsBar = mediaController.controls.controlsBar ;
-
-debug("Default state");
-shouldBeFalse("controlsBar.fadesWhileIdle");
-shouldBeFalse("controlsBar._tapGestureRecognizer.enabled");
-
-controlsBar.fadesWhileIdle = true;
-debug("");
-debug("controlsBar.fadesWhileIdle = true")
-shouldBeTrue("controlsBar.fadesWhileIdle");
-shouldBeTrue("controlsBar._tapGestureRecognizer.enabled");
-
-controlsBar.fadesWhileIdle = false;
-debug("");
-debug("controlsBar.fadesWhileIdle = false")
-shouldBeFalse("controlsBar.fadesWhileIdle");
-shouldBeFalse("controlsBar._tapGestureRecognizer.enabled");
-
-debug("");
-
-</script>
-<script src=""
-</body>
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,14 +0,0 @@
-Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS for audio and also center the controls vertically.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS shadowRoot.querySelector('.media-controls').style.width is "800px"
-PASS shadowRoot.querySelector('.media-controls').style.height is "100px"
-PASS shadowRoot.querySelector('.media-controls').style.zoom is "0.5"
-PASS shadowRoot.querySelector('.media-controls').style.top is "-25px"
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,28 +0,0 @@
-<!DOCTYPE html>
-<script src=""
-<meta name="viewport" content="width=400">
-<body>
-<audio src="" style="position: absolute; top: 100px; left: 0; width: 400px;" controls></audio>
-<script type="text/_javascript_">
-
-window.jsTestIsAsync = true;
-
-description("Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS for audio and also center the controls vertically.");
-
-const media = document.querySelector("audio");
-const shadowRoot = window.internals.shadowRoot(media);
-
-window.requestAnimationFrame(() => {
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.width", "800px");
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.height", "100px");
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.zoom", "0.5");
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.top", "-25px");
-
- debug("");
- media.remove();
- finishJSTest();
-});
-
-</script>
-<script src=""
-</body>
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,14 +0,0 @@
-Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS shadowRoot.querySelector('.media-controls').style.width is "800px"
-PASS shadowRoot.querySelector('.media-controls').style.height is "600px"
-PASS shadowRoot.querySelector('.media-controls').style.zoom is "0.5"
-PASS shadowRoot.querySelector('.media-controls').style.top is "auto"
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-scale-factor.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,28 +0,0 @@
-<!DOCTYPE html>
-<script src=""
-<meta name="viewport" content="width=400">
-<body>
-<video src="" style="position: absolute; top: 0; left: 0; width: 400px; height: 300px;" controls></video>
-<script type="text/_javascript_">
-
-window.jsTestIsAsync = true;
-
-description("Testing that we apply a CSS zoom to ensure controls are always 50 device points tall on iOS.");
-
-const media = document.querySelector("video");
-const shadowRoot = window.internals.shadowRoot(media);
-
-window.requestAnimationFrame(() => {
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.width", "800px");
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.height", "600px");
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.zoom", "0.5");
- shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.top", "auto");
-
- debug("");
- media.remove();
- finishJSTest();
-});
-
-</script>
-<script src=""
-</body>
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,10 +0,0 @@
-Testing the MediaController sizing behavior with tight padding mode.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS !!(mediaController.controls.layoutTraits & LayoutTraits.TightPadding) became true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-tight-padding.html (223175 => 223176)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-tight-padding.html 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-tight-padding.html 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1,31 +0,0 @@
-<script src=""
-<script src="" type="text/_javascript_"></script>
-<style type="text/css" media="screen">
-
- audio, #shadow {
- position: absolute;
- left: 0;
- top: 0;
- width: 400px;
- height: 300px;
- }
-
-</style>
-<body>
-<audio src="" controls autoplay></audio>
-<div id="shadow"></div>
-<script type="text/_javascript_">
-
-window.jsTestIsAsync = true;
-
-description("Testing the <code>MediaController</code> sizing behavior with tight padding mode.");
-
-const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
-const media = document.querySelector("audio");
-const mediaController = createControls(shadowRoot, media, null);
-
-shouldBecomeEqual("!!(mediaController.controls.layoutTraits & LayoutTraits.TightPadding)", "true", finishJSTest);
-
-</script>
-<script src=""
-</body>
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (223175 => 223176)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-10-11 13:51:58 UTC (rev 223176)
@@ -78,6 +78,7 @@
media/modern-media-controls/invalid-placard [ Pass ]
media/modern-media-controls/layout-item [ Pass ]
media/modern-media-controls/layout-node [ Pass ]
+media/modern-media-controls/media-controller [ Pass ]
media/modern-media-controls/media-controls/media-controls-display-above-captions.html [ Pass ]
media/modern-media-controls/media-documents [ Pass ]
media/modern-media-controls/mute-button [ Pass ]
@@ -115,6 +116,7 @@
media/modern-media-controls/button/button.html [ Skip ]
media/modern-media-controls/button/button-active-state.html [ Skip ]
media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Skip ]
+media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
media/modern-media-controls/mute-support/mute-support-press-on-button.html [ Skip ]
media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
media/modern-media-controls/placard-support/ipad [ Skip ]
@@ -127,6 +129,11 @@
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html [ Skip ]
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Skip ]
media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Skip ]
# These tests specifically test iOS-only media controls features
@@ -135,6 +142,13 @@
# These tests are designed to work only on macOS
media/modern-media-controls/button/button-click-on-edges.html [ Skip ]
media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Skip ]
media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]
media/modern-media-controls/playback-support/playback-support-button-click.html [ Skip ]
@@ -141,6 +155,8 @@
media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Skip ]
+webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
+
webkit.org/b/172965 media/track/track-cue-overlap-snap-to-lines-not-set.html [ Failure ]
webkit.org/b/156718 storage/websql/alter-to-info-table.html [ Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (223175 => 223176)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-10-11 13:51:58 UTC (rev 223176)
@@ -1508,6 +1508,7 @@
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-mute-button-in-bottom-or-top-right-controls-bar.html [ Pass ]
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html [ Pass ]
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html [ Pass ]
+media/modern-media-controls/media-controller [ Pass ]
media/modern-media-controls/media-controls/media-controls-display-above-captions.html [ Pass ]
media/modern-media-controls/media-documents [ Pass ]
media/modern-media-controls/mute-button [ Pass ]
@@ -1542,11 +1543,22 @@
# These tests are iOS-specific
media/modern-media-controls/audio/audio-controls-styles.html [ Skip ]
media/modern-media-controls/placard-support/ipad [ Skip ]
+media/modern-media-controls/media-controller/ios [ Skip ]
media/modern-media-controls/media-documents/ipad [ Skip ]
media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html [ Skip ]
media/modern-media-controls/media-documents/media-document-video-ios-sizing.html [ Skip ]
media/modern-media-controls/scrubber-support/ipad [ Skip ]
+# These tests are timing-related and can fail due to performance issues on bots
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Pass Failure ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html [ Pass Failure ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Pass Failure ]
+media/modern-media-controls/media-controller/media-controller-auto-hide.html [ Pass Failure ]
+
+webkit.org/b/178126 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
+webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
+
# This test relies on the control overlay not being visible in the top left. But the test now fails on Mac because
# the image is dumped after the video is loaded and the control overlay is displayed. It seems the test still works
# on iOS, and the bug it was created to regression-test was iOS-only, so there is no hurry to make it work on Mac.
Modified: trunk/LayoutTests/platform/mac-elcapitan/TestExpectations (223175 => 223176)
--- trunk/LayoutTests/platform/mac-elcapitan/TestExpectations 2017-10-11 12:59:36 UTC (rev 223175)
+++ trunk/LayoutTests/platform/mac-elcapitan/TestExpectations 2017-10-11 13:51:58 UTC (rev 223176)
@@ -6,6 +6,7 @@
fast/forms/number/number-appearance-spinbutton-layer.html [ Skip ]
media/modern-media-controls/pip-support [ Skip ]
media/modern-media-controls/button/button-focus-state.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
webkit.org/b/176229 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-query-exception-order.html [ Pass Failure ]
