Title: [223178] trunk
- Revision
- 223178
- Author
- [email protected]
- Date
- 2017-10-11 07:51:29 -0700 (Wed, 11 Oct 2017)
Log Message
[GStreamer] Many media source tests crashing with GStreamer-CRITICAL **: _gst_util_uint64_scale: assertion 'denom != 0' failed in gst_qtdemux_configure_stream()
https://bugs.webkit.org/show_bug.cgi?id=176804
Reviewed by Michael Catanzaro.
Tools:
Add patch to fix assert in qtdemux.
* gstreamer/jhbuild.modules:
* gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added.
LayoutTests:
Update expectations for fixed tests.
* platform/gtk/TestExpectations:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (223177 => 223178)
--- trunk/LayoutTests/ChangeLog 2017-10-11 13:59:44 UTC (rev 223177)
+++ trunk/LayoutTests/ChangeLog 2017-10-11 14:51:29 UTC (rev 223178)
@@ -1,3 +1,14 @@
+2017-10-11 Nael Ouedraogo <[email protected]>
+
+ [GStreamer] Many media source tests crashing with GStreamer-CRITICAL **: _gst_util_uint64_scale: assertion 'denom != 0' failed in gst_qtdemux_configure_stream()
+ https://bugs.webkit.org/show_bug.cgi?id=176804
+
+ Reviewed by Michael Catanzaro.
+
+ Update expectations for fixed tests.
+
+ * platform/gtk/TestExpectations:
+
2017-10-11 Antoine Quint <[email protected]>
Rebaseline tests at media/modern-media-controls/media-controller
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (223177 => 223178)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2017-10-11 13:59:44 UTC (rev 223177)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-10-11 14:51:29 UTC (rev 223178)
@@ -222,11 +222,9 @@
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/URL-createObjectURL-revoke.html [ Failure ]
# See also bug #175578
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Crash Failure ]
-# Crash is webkit.org/b/176804
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Failure Crash ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html [ Failure ]
-# Crash is webkit.org/b/176804
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Failure Crash ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html [ Failure ]
@@ -236,19 +234,16 @@
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v-bitrate.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v-framerate.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v-framesize.html [ Failure ]
-# Crash is webkit.org/b/176804
+# Crash is webkit.org/b/176020
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Failure Crash ]
# Crash in bug #176019
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Failure Crash ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Failure ]
-# Crash is webkit.org/b/176804
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html [ Failure Crash ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported.html [ Failure ]
-# Crash is webkit.org/b/176804
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html [ Failure Crash ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-preload.html [ Failure ]
-# Crash is webkit.org/b/176804
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-remove.html [ Failure Crash ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-remove.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps.html [ Failure ]
@@ -1312,10 +1307,6 @@
webkit.org/b/176803 http/tests/local/blob/send-hybrid-blob-using-open-panel.html [ Crash ]
-webkit.org/b/176804 imported/w3c/web-platform-tests/media-source/mediasource-appendwindow.html [ Crash ]
-webkit.org/b/176804 imported/w3c/web-platform-tests/media-source/mediasource-detach.html [ Crash ]
-webkit.org/b/176804 imported/w3c/web-platform-tests/media-source/mediasource-play.html [ Crash ]
-
webkit.org/b/176805 media/media-higher-prio-audio-stream.html [ Crash ]
webkit.org/b/176806 media/track/track-text-track-cue-list.html [ Crash ]
@@ -3213,14 +3204,11 @@
webkit.org/b/170335 canvas/philip/tests/2d.pattern.animated.gif.html [ Failure ]
webkit.org/b/171598 accessibility/gtk/menu-list-unfocused-notifications.html [ Failure ]
-# Crash is webkit.org/b/176804
-webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html [ Failure Crash ]
+webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html [ Failure ]
# Crash is bug #176020
webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Failure Crash ]
-# Crash is webkit.org/b/176804
-webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure Crash ]
-# Crash is webkit.org/b/176804
-webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Failure Crash ]
+webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure ]
+webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Failure ]
webkit.org/b/171726 media/media-source/media-source-init-segment-duration.html [ Failure ]
webkit.org/b/172270 fast/text/font-interstitial-invisible-width-while-loading.html [ Failure ]
Modified: trunk/Tools/ChangeLog (223177 => 223178)
--- trunk/Tools/ChangeLog 2017-10-11 13:59:44 UTC (rev 223177)
+++ trunk/Tools/ChangeLog 2017-10-11 14:51:29 UTC (rev 223178)
@@ -1,3 +1,15 @@
+2017-10-11 Nael Ouedraogo <[email protected]>
+
+ [GStreamer] Many media source tests crashing with GStreamer-CRITICAL **: _gst_util_uint64_scale: assertion 'denom != 0' failed in gst_qtdemux_configure_stream()
+ https://bugs.webkit.org/show_bug.cgi?id=176804
+
+ Reviewed by Michael Catanzaro.
+
+ Add patch to fix assert in qtdemux.
+
+ * gstreamer/jhbuild.modules:
+ * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added.
+
2017-10-11 Tomas Popela <[email protected]>
Use https for trac changeset and browser links
Modified: trunk/Tools/gstreamer/jhbuild.modules (223177 => 223178)
--- trunk/Tools/gstreamer/jhbuild.modules 2017-10-11 13:59:44 UTC (rev 223177)
+++ trunk/Tools/gstreamer/jhbuild.modules 2017-10-11 14:51:29 UTC (rev 223178)
@@ -78,6 +78,7 @@
<patch file="gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch" strip="1"/>
<patch file="gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch" strip="1"/>
<patch file="gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch" strip="1"/>
+ <patch file="gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch" strip="1"/>
</branch>
</autotools>
Added: trunk/Tools/gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch (0 => 223178)
--- trunk/Tools/gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch (rev 0)
+++ trunk/Tools/gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch 2017-10-11 14:51:29 UTC (rev 223178)
@@ -0,0 +1,28 @@
+From e667ac33dcc039698ee311c22d7b37bedf48df3c Mon Sep 17 00:00:00 2001
+From: Nael Ouedraogo <[email protected]>
+Date: Fri, 22 Sep 2017 18:41:52 +0200
+Subject: [PATCH] qtdemux: fix assert when moof contains one sample
+
+Avoid computing frame rate when a stream contain moof with only one
+sample, to avoid an assert. The moof is considered as still picture.
+---
+ gst/isomp4/qtdemux.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/gst/isomp4/qtdemux.c b/gst/isomp4/qtdemux.c
+index 5f4de422e..f839d82f6 100644
+--- a/gst/isomp4/qtdemux.c
++++ b/gst/isomp4/qtdemux.c
+@@ -7531,7 +7531,8 @@ gst_qtdemux_configure_stream (GstQTDemux * qtdemux, QtDemuxStream * stream)
+ * qt does not have a fixed framerate. */
+ gboolean fps_available = TRUE;
+
+- if ((stream->n_samples == 1) && (stream->first_duration == 0)) {
++ if ((stream->n_samples == 1 && stream->first_duration == 0)
++ || (qtdemux->fragmented && stream->n_samples_moof == 1)) {
+ /* still frame */
+ stream->fps_n = 0;
+ stream->fps_d = 1;
+--
+2.14.1
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
