[webkit-changes] [223261] trunk/Source

Thu, 12 Oct 2017 14:45:05 -0700

Title: [223261] trunk/Source
Revision
223261
Author
[email protected]
Date
2017-10-12 14:44:05 -0700 (Thu, 12 Oct 2017)

Log Message

[iOS] Fix -Wunused-lambda-capture warnings in WebCore/WebKit with new clang compiler
<https://webkit.org/b/178226>

Reviewed by Chris Fleizach.

Source/WebCore:

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]):
- Remove unused lambda variable 'self'.

Source/WebKit:

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):
- Remove unused lambda variable 'touch' which was also passed as
  an argument.
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
- Remove unused lambda variable 'gestureState' which was also
  passed as an argument.
(-[WKContentView _simulateLongPressActionAtLocation:]):
- Remove unused lambda variable 'location'.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (223260 => 223261)


--- trunk/Source/WebCore/ChangeLog	2017-10-12 21:38:04 UTC (rev 223260)
+++ trunk/Source/WebCore/ChangeLog	2017-10-12 21:44:05 UTC (rev 223261)
@@ -1,3 +1,14 @@
+2017-10-12  David Kilzer  <[email protected]>
+
+        [iOS] Fix -Wunused-lambda-capture warnings in WebCore/WebKit with new clang compiler
+        <https://webkit.org/b/178226>
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]):
+        - Remove unused lambda variable 'self'.
+
 2017-10-12  Daniel Bates  <[email protected]>
 
         Mark more InlineBox member functions as const

Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (223260 => 223261)


--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm	2017-10-12 21:38:04 UTC (rev 223260)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm	2017-10-12 21:44:05 UTC (rev 223261)
@@ -560,7 +560,7 @@
 
 - (AccessibilityObjectWrapper*)_accessibilityArticleAncestor
 {
-    if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [self] (const AccessibilityObject& object) {
+    if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) {
         return object.roleValue() == DocumentArticleRole;
     }))
         return parent->wrapper();

Modified: trunk/Source/WebKit/ChangeLog (223260 => 223261)


--- trunk/Source/WebKit/ChangeLog	2017-10-12 21:38:04 UTC (rev 223260)
+++ trunk/Source/WebKit/ChangeLog	2017-10-12 21:44:05 UTC (rev 223261)
@@ -1,3 +1,20 @@
+2017-10-12  David Kilzer  <[email protected]>
+
+        [iOS] Fix -Wunused-lambda-capture warnings in WebCore/WebKit with new clang compiler
+        <https://webkit.org/b/178226>
+
+        Reviewed by Chris Fleizach.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):
+        - Remove unused lambda variable 'touch' which was also passed as
+          an argument.
+        (-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
+        - Remove unused lambda variable 'gestureState' which was also
+          passed as an argument.
+        (-[WKContentView _simulateLongPressActionAtLocation:]):
+        - Remove unused lambda variable 'location'.
+
 2017-10-12  John Wilander  <[email protected]>
 
         ResourceLoadObserver::logFrameNavigation() should use redirectResponse.url()

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (223260 => 223261)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2017-10-12 21:38:04 UTC (rev 223260)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2017-10-12 21:44:05 UTC (rev 223261)
@@ -2577,7 +2577,7 @@
 - (void)changeSelectionWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch baseIsStart:(BOOL)baseIsStart withFlags:(UIWKSelectionFlags)flags
 {
     _usingGestureForSelection = YES;
-    _page->updateSelectionWithTouches(WebCore::IntPoint(point), static_cast<uint32_t>(toSelectionTouch(touch)), baseIsStart, [self, touch, flags](const WebCore::IntPoint& point, uint32_t touch, uint32_t innerFlags, WebKit::CallbackBase::Error error) {
+    _page->updateSelectionWithTouches(WebCore::IntPoint(point), static_cast<uint32_t>(toSelectionTouch(touch)), baseIsStart, [self, flags](const WebCore::IntPoint& point, uint32_t touch, uint32_t innerFlags, WebKit::CallbackBase::Error error) {
         selectionChangedWithTouch(self, point, touch, flags | innerFlags, error);
         if (touch != UIWKSelectionTouchStarted && touch != UIWKSelectionTouchMoved)
             _usingGestureForSelection = NO;
@@ -2587,7 +2587,7 @@
 - (void)changeSelectionWithTouchesFrom:(CGPoint)from to:(CGPoint)to withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)gestureState
 {
     _usingGestureForSelection = YES;
-    _page->selectWithTwoTouches(WebCore::IntPoint(from), WebCore::IntPoint(to), static_cast<uint32_t>(toGestureType(gestureType)), static_cast<uint32_t>(toGestureRecognizerState(gestureState)), [self, gestureState](const WebCore::IntPoint& point, uint32_t gestureType, uint32_t gestureState, uint32_t flags, WebKit::CallbackBase::Error error) {
+    _page->selectWithTwoTouches(WebCore::IntPoint(from), WebCore::IntPoint(to), static_cast<uint32_t>(toGestureType(gestureType)), static_cast<uint32_t>(toGestureRecognizerState(gestureState)), [self](const WebCore::IntPoint& point, uint32_t gestureType, uint32_t gestureState, uint32_t flags, WebKit::CallbackBase::Error error) {
         selectionChangedWithGesture(self, point, gestureType, gestureState, flags, error);
         if (gestureState == UIGestureRecognizerStateEnded || gestureState == UIGestureRecognizerStateCancelled)
             _usingGestureForSelection = NO;
@@ -4855,7 +4855,7 @@
 - (void)_simulateLongPressActionAtLocation:(CGPoint)location
 {
     RetainPtr<WKContentView> protectedSelf = self;
-    [self doAfterPositionInformationUpdate:[location, protectedSelf] (InteractionInformationAtPosition) {
+    [self doAfterPositionInformationUpdate:[protectedSelf] (InteractionInformationAtPosition) {
         if (SEL action = "" _actionForLongPress])
             [protectedSelf performSelector:action];
     } forRequest:InteractionInformationRequest(roundedIntPoint(location))];

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to