Title: [223309] trunk/Source/WebCore
- Revision
- 223309
- Author
- [email protected]
- Date
- 2017-10-13 17:02:16 -0700 (Fri, 13 Oct 2017)
Log Message
Crash under ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData
https://bugs.webkit.org/show_bug.cgi?id=178279
Reviewed by Alex Christensen.
Check if the connection is valid before calling ResourceHandleClient::didSendData.
No new tests, covered by existing tests.
* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (223308 => 223309)
--- trunk/Source/WebCore/ChangeLog 2017-10-13 23:52:34 UTC (rev 223308)
+++ trunk/Source/WebCore/ChangeLog 2017-10-14 00:02:16 UTC (rev 223309)
@@ -1,3 +1,17 @@
+2017-10-13 Per Arne Vollan <[email protected]>
+
+ Crash under ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData
+ https://bugs.webkit.org/show_bug.cgi?id=178279
+
+ Reviewed by Alex Christensen.
+
+ Check if the connection is valid before calling ResourceHandleClient::didSendData.
+
+ No new tests, covered by existing tests.
+
+ * platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
+ (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
+
2017-10-13 Brent Fulgham <[email protected]>
CMD+R / CMD+Q keyboard shortcuts are treated as user interaction with page
Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp (223308 => 223309)
--- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp 2017-10-13 23:52:34 UTC (rev 223308)
+++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp 2017-10-14 00:02:16 UTC (rev 223309)
@@ -347,7 +347,7 @@
{
auto work = [protectedThis = makeRef(*this), totalBytesWritten, totalBytesExpectedToWrite] () mutable {
auto& handle = protectedThis->m_handle;
- if (!protectedThis->hasHandle() || !handle->client())
+ if (!protectedThis->hasHandle() || !handle->client() || !handle->connection())
return;
LOG(Network, "CFNet - ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData(handle=%p) (%s)", handle, handle->firstRequest().url().string().utf8().data());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
