Title: [223433] trunk
Revision
223433
Author
[email protected]
Date
2017-10-16 13:36:18 -0700 (Mon, 16 Oct 2017)

Log Message

Activate Cache API by default
https://bugs.webkit.org/show_bug.cgi?id=178186

Patch by Youenn Fablet <[email protected]> on 2017-10-16
Reviewed by Chris Dumez.

Source/WebKit:

* Shared/WebPreferencesDefinitions.h:

Tools:

Removing explicit activation of cache api.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setCacheAPIEnabled): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (223432 => 223433)


--- trunk/Source/WebKit/ChangeLog	2017-10-16 20:33:32 UTC (rev 223432)
+++ trunk/Source/WebKit/ChangeLog	2017-10-16 20:36:18 UTC (rev 223433)
@@ -1,3 +1,12 @@
+2017-10-16  Youenn Fablet  <[email protected]>
+
+        Activate Cache API by default
+        https://bugs.webkit.org/show_bug.cgi?id=178186
+
+        Reviewed by Chris Dumez.
+
+        * Shared/WebPreferencesDefinitions.h:
+
 2017-10-16  Sam Weinig  <[email protected]>
 
         [Settings] Remove all custom code from Settings.h/cpp

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefinitions.h (223432 => 223433)


--- trunk/Source/WebKit/Shared/WebPreferencesDefinitions.h	2017-10-16 20:33:32 UTC (rev 223432)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefinitions.h	2017-10-16 20:36:18 UTC (rev 223433)
@@ -374,7 +374,7 @@
 
 #define FOR_EACH_WEBKIT_EXPERIMENTAL_FEATURE_PREFERENCE(macro) \
     macro(AsyncFrameScrollingEnabled, asyncFrameScrollingEnabled, Bool, bool, false, "Async Frame Scrolling", "Perform frame scrolling in a dedicated thread or process") \
-    macro(CacheAPIEnabled, cacheAPIEnabled, Bool, bool, false, "Cache API", "Enable Cache API") \
+    macro(CacheAPIEnabled, cacheAPIEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Cache API", "Enable Cache API") \
     macro(ConstantPropertiesEnabled, constantPropertiesEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Constant Properties", "Enable CSS constant() properties") \
     macro(DisplayContentsEnabled, displayContentsEnabled, Bool, bool, false, "CSS display: contents", "Enable CSS display: contents support") \
     macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "CSS Spring Animations", "CSS Spring Animation prototype") \

Modified: trunk/Tools/ChangeLog (223432 => 223433)


--- trunk/Tools/ChangeLog	2017-10-16 20:33:32 UTC (rev 223432)
+++ trunk/Tools/ChangeLog	2017-10-16 20:36:18 UTC (rev 223433)
@@ -1,3 +1,18 @@
+2017-10-16  Youenn Fablet  <[email protected]>
+
+        Activate Cache API by default
+        https://bugs.webkit.org/show_bug.cgi?id=178186
+
+        Reviewed by Chris Dumez.
+
+        Removing explicit activation of cache api.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+        (WTR::InjectedBundle::beginTesting):
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setCacheAPIEnabled): Deleted.
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
 2017-10-16  Ross Kirsling  <[email protected]>
 
         run-webkit-tests help text should mention arguments too

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (223432 => 223433)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp	2017-10-16 20:33:32 UTC (rev 223432)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp	2017-10-16 20:36:18 UTC (rev 223433)
@@ -355,8 +355,6 @@
     m_testRunner->setWebGL2Enabled(true);
     m_testRunner->setWebGPUEnabled(true);
 
-    m_testRunner->setCacheAPIEnabled(true);
-
     m_testRunner->setWritableStreamAPIEnabled(true);
     m_testRunner->setReadableByteStreamAPIEnabled(true);
 

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (223432 => 223433)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2017-10-16 20:33:32 UTC (rev 223432)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2017-10-16 20:36:18 UTC (rev 223433)
@@ -399,13 +399,6 @@
     WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
 }
 
-void TestRunner::setCacheAPIEnabled(bool enabled)
-{
-    WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitCacheAPIEnabled"));
-    auto& injectedBundle = InjectedBundle::singleton();
-    WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
 void TestRunner::setWritableStreamAPIEnabled(bool enabled)
 {
     WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitWritableStreamAPIEnabled"));

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (223432 => 223433)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h	2017-10-16 20:33:32 UTC (rev 223432)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h	2017-10-16 20:36:18 UTC (rev 223433)
@@ -102,7 +102,6 @@
     void setModernMediaControlsEnabled(bool);
     void setWebGL2Enabled(bool);
     void setWebGPUEnabled(bool);
-    void setCacheAPIEnabled(bool);
     void setWritableStreamAPIEnabled(bool);
     void setReadableByteStreamAPIEnabled(bool);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to