Title: [223445] trunk/LayoutTests
Revision
223445
Author
[email protected]
Date
2017-10-16 16:10:00 -0700 (Mon, 16 Oct 2017)

Log Message

De-flakify http/tests/loading/basic-credentials-sent-automatically.html
https://bugs.webkit.org/show_bug.cgi?id=178365

Reviewed by Andy Estes.

* http/tests/loading/basic-credentials-sent-automatically-expected.txt:
* http/tests/loading/basic-credentials-sent-automatically.html:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (223444 => 223445)


--- trunk/LayoutTests/ChangeLog	2017-10-16 23:03:28 UTC (rev 223444)
+++ trunk/LayoutTests/ChangeLog	2017-10-16 23:10:00 UTC (rev 223445)
@@ -1,3 +1,16 @@
+2017-10-16  Alex Christensen  <[email protected]>
+
+        De-flakify http/tests/loading/basic-credentials-sent-automatically.html
+        https://bugs.webkit.org/show_bug.cgi?id=178365
+
+        Reviewed by Andy Estes.
+
+        * http/tests/loading/basic-credentials-sent-automatically-expected.txt:
+        * http/tests/loading/basic-credentials-sent-automatically.html:
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+        * platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
+
 2017-10-15  Ryosuke Niwa  <[email protected]>
 
         Cannot access images included in the content pasted from Microsoft Word

Modified: trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt (223444 => 223445)


--- trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt	2017-10-16 23:03:28 UTC (rev 223444)
+++ trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt	2017-10-16 23:10:00 UTC (rev 223445)
@@ -1,7 +1,8 @@
 main frame - didStartProvisionalLoadForFrame
 main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
 http://127.0.0.1:8000/loading/resources/subresources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with first:first-pw
 frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -22,7 +23,6 @@
 frame "<!--framePath //<!--frame3-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame3-->-->" - didFinishDocumentLoadForFrame
 frame "<!--framePath //<!--frame3-->-->" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
 frame "<!--framePath //<!--frame3-->-->" - didFinishLoadForFrame
 main frame - didFinishLoadForFrame
 This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
@@ -34,8 +34,8 @@
 It will be authorized with second/second-pw.
 The fourth frame's path is /loading/resources/othersubresources/protected-resource.php, and we should *not* get a challenge for it, because it has a common subpath with the previously authorized second and third frames.
 It will be authorized with second/second-pw.
-  
 
+
 --------
 Frame: '<!--framePath //<!--frame0-->-->'
 --------

Modified: trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html (223444 => 223445)


--- trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html	2017-10-16 23:03:28 UTC (rev 223444)
+++ trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html	2017-10-16 23:10:00 UTC (rev 223445)
@@ -52,9 +52,16 @@
         testRunner.notifyDone();
 }
 
+function makeIFrame() {
+    var iframe = document.createElement("iframe");
+    iframe._onload_=firstFrameLoaded;
+    iframe.src=""
+    document.body.appendChild(iframe);
+}
+
 </script>
 </head>
-<body>
+<body _onload_="makeIFrame()">
 This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.<br>
 The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.<br>
 It will be authorized with first/first-pw.<br>
@@ -64,6 +71,5 @@
 It will be authorized with second/second-pw.<br>
 The fourth frame's path is /loading/resources/othersubresources/protected-resource.php, and we should *not* get a challenge for it, because it has a common subpath with the previously authorized second and third frames.<br>
 It will be authorized with second/second-pw.<br>
-<iframe src="" _onload_="firstFrameLoaded();"></iframe>
 </body>
 </html>

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (223444 => 223445)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-10-16 23:03:28 UTC (rev 223444)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-10-16 23:10:00 UTC (rev 223445)
@@ -1860,8 +1860,6 @@
 
 webkit.org/b/159881 [ Release ] fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/159427 http/tests/loading/basic-credentials-sent-automatically.html [ Pass Failure ]
-
 webkit.org/b/160368 http/tests/xmlhttprequest/workers/methods-async.html [ Pass Timeout ]
 
 webkit.org/b/161323 media/track/media-element-enqueue-event-crash.html [ Skip ]

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (223444 => 223445)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-10-16 23:03:28 UTC (rev 223444)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-10-16 23:10:00 UTC (rev 223445)
@@ -625,8 +625,6 @@
 
 webkit.org/b/160042 accessibility/mac/value-change/value-change-user-info-contenteditable.html [ Pass Failure ]
 
-webkit.org/b/159427 http/tests/loading/basic-credentials-sent-automatically.html [ Pass Failure ]
-
 webkit.org/b/160309 fast/dom/Window/child-window-focus.html [ Pass Failure ]
 
 webkit.org/b/161148 gamepad/gamepad-timestamp.html [ Pass Failure ]

Modified: trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt (223444 => 223445)


--- trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	2017-10-16 23:03:28 UTC (rev 223444)
+++ trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt	2017-10-16 23:10:00 UTC (rev 223445)
@@ -1,7 +1,8 @@
 main frame - didStartProvisionalLoadForFrame
 main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
 127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with first:first-pw
 frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -22,7 +23,6 @@
 frame "<!--framePath //<!--frame3-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame3-->-->" - didFinishDocumentLoadForFrame
 frame "<!--framePath //<!--frame3-->-->" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
 frame "<!--framePath //<!--frame3-->-->" - didFinishLoadForFrame
 main frame - didFinishLoadForFrame
 This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
@@ -34,8 +34,8 @@
 It will be authorized with second/second-pw.
 The fourth frame's path is /loading/resources/othersubresources/protected-resource.php, and we should *not* get a challenge for it, because it has a common subpath with the previously authorized second and third frames.
 It will be authorized with second/second-pw.
-  
 
+
 --------
 Frame: '<!--framePath //<!--frame0-->-->'
 --------
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to