Title: [223448] trunk
- Revision
- 223448
- Author
- [email protected]
- Date
- 2017-10-16 17:03:30 -0700 (Mon, 16 Oct 2017)
Log Message
DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
https://bugs.webkit.org/show_bug.cgi?id=178366
Reviewed by Youenn Fablet.
Source/WebCore:
DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]. We attempted to do so using JSDOMQuad::visitAdditionalChildren()
but the code did not work because we failed to generate a "isReachableFromOpaqueRoots()" function for JSDOMPoint.
Test: fast/css/DOMQuad-points-SameObject.html
* dom/DOMPoint.idl:
LayoutTests:
Add layout test coverage.
* fast/css/DOMQuad-points-SameObject.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (223447 => 223448)
--- trunk/LayoutTests/ChangeLog 2017-10-17 00:00:40 UTC (rev 223447)
+++ trunk/LayoutTests/ChangeLog 2017-10-17 00:03:30 UTC (rev 223448)
@@ -1,3 +1,14 @@
+2017-10-16 Chris Dumez <[email protected]>
+
+ DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
+ https://bugs.webkit.org/show_bug.cgi?id=178366
+
+ Reviewed by Youenn Fablet.
+
+ Add layout test coverage.
+
+ * fast/css/DOMQuad-points-SameObject.html: Added.
+
2017-10-16 Andy Estes <[email protected]>
[Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact and ApplePayError
Added: trunk/LayoutTests/fast/css/DOMQuad-points-SameObject.html (0 => 223448)
--- trunk/LayoutTests/fast/css/DOMQuad-points-SameObject.html (rev 0)
+++ trunk/LayoutTests/fast/css/DOMQuad-points-SameObject.html 2017-10-17 00:03:30 UTC (rev 223448)
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Tests that DOMQuad.p1 / p2 / p3 / p4 is [SameObject].");
+jsTestIsAsync = true;
+
+let quad = new DOMQuad();
+quad.p1.foo = 1;
+quad.p2.foo = 2;
+quad.p3.foo = 3;
+quad.p4.foo = 4;
+
+shouldBe("quad.p1.foo", "1");
+shouldBe("quad.p2.foo", "2");
+shouldBe("quad.p3.foo", "3");
+shouldBe("quad.p4.foo", "4");
+
+gc();
+
+shouldBe("quad.p1.foo", "1");
+shouldBe("quad.p2.foo", "2");
+shouldBe("quad.p3.foo", "3");
+shouldBe("quad.p4.foo", "4");
+
+setTimeout(function() {
+ gc();
+
+ shouldBe("quad.p1.foo", "1");
+ shouldBe("quad.p2.foo", "2");
+ shouldBe("quad.p3.foo", "3");
+ shouldBe("quad.p4.foo", "4");
+
+ finishJSTest();
+}, 0);
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (223447 => 223448)
--- trunk/Source/WebCore/ChangeLog 2017-10-17 00:00:40 UTC (rev 223447)
+++ trunk/Source/WebCore/ChangeLog 2017-10-17 00:03:30 UTC (rev 223448)
@@ -1,3 +1,17 @@
+2017-10-16 Chris Dumez <[email protected]>
+
+ DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
+ https://bugs.webkit.org/show_bug.cgi?id=178366
+
+ Reviewed by Youenn Fablet.
+
+ DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]. We attempted to do so using JSDOMQuad::visitAdditionalChildren()
+ but the code did not work because we failed to generate a "isReachableFromOpaqueRoots()" function for JSDOMPoint.
+
+ Test: fast/css/DOMQuad-points-SameObject.html
+
+ * dom/DOMPoint.idl:
+
2017-10-16 Andy Estes <[email protected]>
[Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact and ApplePayError
Modified: trunk/Source/WebCore/dom/DOMPoint.idl (223447 => 223448)
--- trunk/Source/WebCore/dom/DOMPoint.idl 2017-10-17 00:00:40 UTC (rev 223447)
+++ trunk/Source/WebCore/dom/DOMPoint.idl 2017-10-17 00:03:30 UTC (rev 223448)
@@ -34,6 +34,7 @@
Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
optional unrestricted double z = 0, optional unrestricted double w = 1),
Exposed=(Window,Worker),
+ GenerateIsReachable=Impl,
ImplementationLacksVTable
]
interface DOMPoint : DOMPointReadOnly {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
