Title: [223507] releases/WebKitGTK/webkit-2.18
- Revision
- 223507
- Author
- [email protected]
- Date
- 2017-10-17 02:48:50 -0700 (Tue, 17 Oct 2017)
Log Message
Merge r222832 - AX: [ATK] ARIA tabpanel role should be exposed as ATK_ROLE_SCROLL_PANE
https://bugs.webkit.org/show_bug.cgi?id=177815
Reviewed by Chris Fleizach.
Source/WebCore:
Change the mapping of TabPanelRole from ATK_ROLE_PANEL to ATK_ROLE_SCROLL_PANE.
No new tests because this mapping is already covered by aria-tab-roles.html and
roles-exposed.html. The platform expectations for each test have been updated.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
Updated expectations to reflect new mapping.
* platform/gtk/accessibility/aria-tab-roles-expected.txt: Added.
* platform/gtk/accessibility/roles-exposed-expected.txt: Updated.
Modified Paths
Added Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog (223506 => 223507)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-10-17 09:47:06 UTC (rev 223506)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-10-17 09:48:50 UTC (rev 223507)
@@ -1,3 +1,15 @@
+2017-10-04 Joanmarie Diggs <[email protected]>
+
+ AX: [ATK] ARIA tabpanel role should be exposed as ATK_ROLE_SCROLL_PANE
+ https://bugs.webkit.org/show_bug.cgi?id=177815
+
+ Reviewed by Chris Fleizach.
+
+ Updated expectations to reflect new mapping.
+
+ * platform/gtk/accessibility/aria-tab-roles-expected.txt: Added.
+ * platform/gtk/accessibility/roles-exposed-expected.txt: Updated.
+
2017-10-03 Joanmarie Diggs <[email protected]>
AX: [ATK] ARIA menuitems should be exposed with ATK_ROLE_MENU_ITEM even when it's the child of group role
Added: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/accessibility/aria-tab-roles-expected.txt (0 => 223507)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/accessibility/aria-tab-roles-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/accessibility/aria-tab-roles-expected.txt 2017-10-17 09:48:50 UTC (rev 223507)
@@ -0,0 +1,21 @@
+Crust
+Veges
+Select Crust
+
+This tests that the aria roles for tab, tabpanel and tablist work as expected correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+tabList.role = AXRole: AXTabGroup
+tab1.role = AXRole: AXTab
+tab1.title = AXTitle: Crust
+PASS tab1.childrenCount is 0
+tab2.role = AXRole: AXTab
+tab2.title = AXTitle: Veges
+tabPanel.role = AXRole: AXScrollArea
+tabPanel.subrole =
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt (223506 => 223507)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2017-10-17 09:47:06 UTC (rev 223506)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt 2017-10-17 09:48:50 UTC (rev 223507)
@@ -788,7 +788,7 @@
AXRole: AXTab
div[role=tabpanel]
- AXRole: AXGroup
+ AXRole: AXScrollArea
div[role=term]
AXRole: AXDescriptionTerm
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog (223506 => 223507)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-10-17 09:47:06 UTC (rev 223506)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-10-17 09:48:50 UTC (rev 223507)
@@ -1,3 +1,18 @@
+2017-10-04 Joanmarie Diggs <[email protected]>
+
+ AX: [ATK] ARIA tabpanel role should be exposed as ATK_ROLE_SCROLL_PANE
+ https://bugs.webkit.org/show_bug.cgi?id=177815
+
+ Reviewed by Chris Fleizach.
+
+ Change the mapping of TabPanelRole from ATK_ROLE_PANEL to ATK_ROLE_SCROLL_PANE.
+
+ No new tests because this mapping is already covered by aria-tab-roles.html and
+ roles-exposed.html. The platform expectations for each test have been updated.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole):
+
2017-10-03 Zalan Bujtas <[email protected]>
Move scroll snap point unregistration from willBeRemovedFromTree to willBeDestroyed
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (223506 => 223507)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2017-10-17 09:47:06 UTC (rev 223506)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2017-10-17 09:48:50 UTC (rev 223507)
@@ -687,6 +687,7 @@
case ScrollBarRole:
return ATK_ROLE_SCROLL_BAR;
case ScrollAreaRole:
+ case TabPanelRole:
return ATK_ROLE_SCROLL_PANE;
case GridRole:
case TableRole:
@@ -701,7 +702,6 @@
case GroupRole:
case RadioGroupRole:
case SVGRootRole:
- case TabPanelRole:
return ATK_ROLE_PANEL;
case RowHeaderRole:
return ATK_ROLE_ROW_HEADER;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
