Title: [223613] trunk/LayoutTests
- Revision
- 223613
- Author
- [email protected]
- Date
- 2017-10-18 10:16:41 -0700 (Wed, 18 Oct 2017)
Log Message
http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure after proposed fix.
https://bugs.webkit.org/show_bug.cgi?id=178467
Reviewed by Andy Estes.
* http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
* http/tests/loading/basic-auth-resend-wrong-credentials.html:
* platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
Use setTimeout to make the loading order deterministic.
The important part of this test is that the passwords shown in the delegate callbacks are correct,
and this doesn't change that.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (223612 => 223613)
--- trunk/LayoutTests/ChangeLog 2017-10-18 17:10:16 UTC (rev 223612)
+++ trunk/LayoutTests/ChangeLog 2017-10-18 17:16:41 UTC (rev 223613)
@@ -1,3 +1,17 @@
+2017-10-18 Alex Christensen <[email protected]>
+
+ http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure after proposed fix.
+ https://bugs.webkit.org/show_bug.cgi?id=178467
+
+ Reviewed by Andy Estes.
+
+ * http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+ * http/tests/loading/basic-auth-resend-wrong-credentials.html:
+ * platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+ Use setTimeout to make the loading order deterministic.
+ The important part of this test is that the passwords shown in the delegate callbacks are correct,
+ and this doesn't change that.
+
2017-10-18 Ms2ger <[email protected]>
[GTK] Test gardening.
Modified: trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt (223612 => 223613)
--- trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-18 17:10:16 UTC (rev 223612)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-18 17:16:41 UTC (rev 223613)
@@ -1,8 +1,9 @@
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didHandleOnloadEventsForFrame
http://127.0.0.1:8000/loading/resources/test2/protected-resource.php - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -12,9 +13,6 @@
http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
-frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
Modified: trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html (223612 => 223613)
--- trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html 2017-10-18 17:10:16 UTC (rev 223612)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html 2017-10-18 17:16:41 UTC (rev 223613)
@@ -36,7 +36,7 @@
</script>
</head>
-<body _onload_="makeIFrame()">
+<body _onload_="setTimeout(makeIFrame, 0)">
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.<br>
</body>
</html>
Modified: trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt (223612 => 223613)
--- trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-18 17:10:16 UTC (rev 223612)
+++ trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-18 17:16:41 UTC (rev 223613)
@@ -1,8 +1,9 @@
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didHandleOnloadEventsForFrame
127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -12,9 +13,6 @@
127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
-frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
