Title: [223616] trunk/Source/WebKit
Revision
223616
Author
[email protected]
Date
2017-10-18 11:21:16 -0700 (Wed, 18 Oct 2017)

Log Message

Check notifyPagesWhenTelemetryWasCaptured before notifying pages if there is no WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=178470
<rdar://problem/34417518>

Reviewed by Brian Burg.

* UIProcess/WebResourceLoadStatisticsTelemetry.cpp:
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):
    Add a missing check of notifyPagesWhenTelemetryWasCaptured.
    The page notification is only for testing purposes.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (223615 => 223616)


--- trunk/Source/WebKit/ChangeLog	2017-10-18 17:56:05 UTC (rev 223615)
+++ trunk/Source/WebKit/ChangeLog	2017-10-18 18:21:16 UTC (rev 223616)
@@ -1,3 +1,16 @@
+2017-10-18  John Wilander  <[email protected]>
+
+        Check notifyPagesWhenTelemetryWasCaptured before notifying pages if there is no WebPageProxy
+        https://bugs.webkit.org/show_bug.cgi?id=178470
+        <rdar://problem/34417518>
+
+        Reviewed by Brian Burg.
+
+        * UIProcess/WebResourceLoadStatisticsTelemetry.cpp:
+        (WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):
+            Add a missing check of notifyPagesWhenTelemetryWasCaptured.
+            The page notification is only for testing purposes.
+
 2017-10-18  Chris Dumez  <[email protected]>
 
         Unreviewed, fix build error after r223608 with some SDKs.

Modified: trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsTelemetry.cpp (223615 => 223616)


--- trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsTelemetry.cpp	2017-10-18 17:56:05 UTC (rev 223615)
+++ trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsTelemetry.cpp	2017-10-18 18:21:16 UTC (rev 223616)
@@ -248,7 +248,8 @@
     
     auto webPageProxy = nonEphemeralWebPageProxy();
     if (!webPageProxy) {
-        notifyPages(0, 0, 0);
+        if (notifyPagesWhenTelemetryWasCaptured)
+            notifyPages(0, 0, 0);
         return;
     }
     
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to