Title: [223643] trunk/Tools
Revision
223643
Author
[email protected]
Date
2017-10-18 17:46:15 -0700 (Wed, 18 Oct 2017)

Log Message

update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
https://bugs.webkit.org/show_bug.cgi?id=178381

Patch by Fujii Hironori <[email protected]> on 2017-10-18
Reviewed by Alexey Proskuryakov.

The web server developer.apple.com seems to reject HTTP requests
without Accept header field.

* Scripts/update-webkit-dependency: Add 'Accept' header field to requests.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (223642 => 223643)


--- trunk/Tools/ChangeLog	2017-10-18 23:59:42 UTC (rev 223642)
+++ trunk/Tools/ChangeLog	2017-10-19 00:46:15 UTC (rev 223643)
@@ -1,3 +1,15 @@
+2017-10-18  Fujii Hironori  <[email protected]>
+
+        update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
+        https://bugs.webkit.org/show_bug.cgi?id=178381
+
+        Reviewed by Alexey Proskuryakov.
+
+        The web server developer.apple.com seems to reject HTTP requests
+        without Accept header field.
+
+        * Scripts/update-webkit-dependency: Add 'Accept' header field to requests.
+
 2017-10-18  Aakash Jain  <[email protected]>
 
         webkitpy tests should have --json-output option

Modified: trunk/Tools/Scripts/update-webkit-dependency (223642 => 223643)


--- trunk/Tools/Scripts/update-webkit-dependency	2017-10-18 23:59:42 UTC (rev 223642)
+++ trunk/Tools/Scripts/update-webkit-dependency	2017-10-19 00:46:15 UTC (rev 223643)
@@ -95,7 +95,7 @@
 # errors for those requests. Instead we can just set a size limit for a GET request (which we can also set the range for
 # to request just the first byte) so that we don't have to retrieve the entire file.
 $ua->max_size(0);
-my $response = $ua->get($libsURL, "Range", "bytes=0-0");
+my $response = $ua->get($libsURL, Accept => '*/*', Range => "bytes=0-0");
 $ua->max_size(undef);
 
 if (! $response->is_success) {
@@ -191,8 +191,10 @@
 
 print "Downloading $zipFile...\n\n";
 print "$libsURL\n";
-my $result = getstore($libsURL, File::Spec->catfile($tmpAbsDir, $zipFile));
-die "Couldn't download $zipFile!" if is_error($result);
+my $request = HTTP::Request->new(GET => $libsURL);
+$request->header(Accept => "*/*");
+$response = $ua->request($request, File::Spec->catfile($tmpAbsDir, $zipFile));
+die "Couldn't download $zipFile!" if is_error($response->code);
 
 my $zip = Archive::Zip->new(File::Spec->catfile($tmpAbsDir, $zipFile));
 
@@ -211,7 +213,7 @@
     }
 }
 
-$result = $zip->extractTree("", $tmpAbsDir);
+my $result = $zip->extractTree("", $tmpAbsDir);
 die "Couldn't unzip $zipFile." if $result != AZ_OK;
 
 print "\nInstalling $file...\n";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to