[webkit-changes] [223683] trunk/Source/WebCore

Thu, 19 Oct 2017 01:27:33 -0700

Title: [223683] trunk/Source/WebCore
Revision
223683
Author
[email protected]
Date
2017-10-19 01:27:10 -0700 (Thu, 19 Oct 2017)

Log Message

Update the signatures of compressedTexSubImage3D.
https://bugs.webkit.org/show_bug.cgi?id=178507

Reviewed by Ryosuke Niwa.

No new tests: not much point in adding tests now; this method doesn't
do anything anyway.

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGL2RenderingContext.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (223682 => 223683)


--- trunk/Source/WebCore/ChangeLog	2017-10-19 08:20:59 UTC (rev 223682)
+++ trunk/Source/WebCore/ChangeLog	2017-10-19 08:27:10 UTC (rev 223683)
@@ -1,3 +1,18 @@
+2017-10-19  Ms2ger  <[email protected]>
+
+        Update the signatures of compressedTexSubImage3D.
+        https://bugs.webkit.org/show_bug.cgi?id=178507
+
+        Reviewed by Ryosuke Niwa.
+
+        No new tests: not much point in adding tests now; this method doesn't
+        do anything anyway.
+
+        * html/canvas/WebGL2RenderingContext.cpp:
+        (WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
+        * html/canvas/WebGL2RenderingContext.h:
+        * html/canvas/WebGL2RenderingContext.idl:
+
 2017-10-19  Basuke Suzuki  <[email protected]>
 
         [curl] Segfault in WebCore::CurlRequest::setupPOST

Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp (223682 => 223683)


--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp	2017-10-19 08:20:59 UTC (rev 223682)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp	2017-10-19 08:27:10 UTC (rev 223683)
@@ -551,10 +551,14 @@
 {
 }
 
-void WebGL2RenderingContext::compressedTexSubImage3D(GC3Denum, GC3Dint, GC3Dint, GC3Dint, GC3Dint, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Denum, GC3Dsizei, RefPtr<ArrayBufferView>&&)
+void WebGL2RenderingContext::compressedTexSubImage3D(GC3Denum, GC3Dint, GC3Dint, GC3Dint, GC3Dint, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Denum, GC3Dsizei, GC3Dint64)
 {
 }
 
+void WebGL2RenderingContext::compressedTexSubImage3D(GC3Denum, GC3Dint, GC3Dint, GC3Dint, GC3Dint, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Denum, ArrayBufferView&, GC3Duint, GC3Duint)
+{
+}
+
 GC3Dint WebGL2RenderingContext::getFragDataLocation(WebGLProgram&, const String&)
 {
     return 0;

Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h (223682 => 223683)


--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h	2017-10-19 08:20:59 UTC (rev 223682)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h	2017-10-19 08:27:10 UTC (rev 223683)
@@ -92,8 +92,10 @@
     void compressedTexImage2D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dint border, ArrayBufferView& data, GC3Duint, GC3Duint);
     void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, GC3Dsizei imageSize, GC3Dint64 offset);
     void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, ArrayBufferView& srcData, GC3Duint srcOffset, GC3Duint srcLengthOverride);
-    void compressedTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Denum format, GC3Dsizei imageSize, RefPtr<ArrayBufferView>&& data);
-    
+
+    void compressedTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Denum format, GC3Dsizei imageSize, GC3Dint64 offset);
+    void compressedTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Denum format, ArrayBufferView& data, GC3Duint srcOffset, GC3Duint srcLengthOverride);
+
     // Programs and shaders
     GC3Dint getFragDataLocation(WebGLProgram&, const String& name);

Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl (223682 => 223683)


--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl	2017-10-19 08:20:59 UTC (rev 223682)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl	2017-10-19 08:27:10 UTC (rev 223683)
@@ -396,7 +396,8 @@
 
     void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLsizei imageSize, GLintptr offset);
     void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, ArrayBufferView srcData, optional GLuint srcOffset = 0, optional GLuint srcLengthOverride = 0);
-    void compressedTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLsizei imageSize, ArrayBufferView? data);
+    void compressedTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLsizei imageSize, GLintptr offset);
+    void compressedTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, ArrayBufferView srcData, optional GLuint srcOffset = 0, optional GLuint srcLengthOverride = 0);
 
     /* Programs and shaders */
     GLint getFragDataLocation(WebGLProgram program, DOMString name);

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to