Title: [223794] trunk/Source/WebCore
- Revision
- 223794
- Author
- [email protected]
- Date
- 2017-10-20 13:58:49 -0700 (Fri, 20 Oct 2017)
Log Message
Use "= default" for more default constructors and destructors in WebCore
https://bugs.webkit.org/show_bug.cgi?id=178585
Patch by Daniel Bates <[email protected]> on 2017-10-20
Reviewed by Alex Christensen.
Also remove some destructors that would be implicitly generated.
* Modules/applepay/PaymentMerchantSession.h:
(WebCore::PaymentMerchantSession::~PaymentMerchantSession): Deleted.
* platform/ControlStates.h:
(WebCore::ControlStates::~ControlStates): Deleted.
* platform/PlatformEvent.h:
(WebCore::PlatformEvent::~PlatformEvent): Use default.
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies): Ditto.
* platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext): Deleted.
(GIFImageReader::~GIFImageReader): Deleted.
* rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::~RenderBlockFlowRareData): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (223793 => 223794)
--- trunk/Source/WebCore/ChangeLog 2017-10-20 20:58:09 UTC (rev 223793)
+++ trunk/Source/WebCore/ChangeLog 2017-10-20 20:58:49 UTC (rev 223794)
@@ -1,3 +1,27 @@
+2017-10-20 Daniel Bates <[email protected]>
+
+ Use "= default" for more default constructors and destructors in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=178585
+
+ Reviewed by Alex Christensen.
+
+ Also remove some destructors that would be implicitly generated.
+
+ * Modules/applepay/PaymentMerchantSession.h:
+ (WebCore::PaymentMerchantSession::~PaymentMerchantSession): Deleted.
+ * platform/ControlStates.h:
+ (WebCore::ControlStates::~ControlStates): Deleted.
+ * platform/PlatformEvent.h:
+ (WebCore::PlatformEvent::~PlatformEvent): Use default.
+ * platform/PlatformStrategies.h:
+ (WebCore::PlatformStrategies::PlatformStrategies): Ditto.
+ * platform/image-decoders/gif/GIFImageReader.h:
+ (GIFFrameContext::GIFFrameContext):
+ (GIFFrameContext::~GIFFrameContext): Deleted.
+ (GIFImageReader::~GIFImageReader): Deleted.
+ * rendering/RenderBlockFlow.h:
+ (WebCore::RenderBlockFlow::RenderBlockFlowRareData::~RenderBlockFlowRareData): Deleted.
+
2017-10-20 Zalan Bujtas <[email protected]>
[FrameView::layout cleanup] Scheduling layout should be disabled for FrameView::layout
Modified: trunk/Source/WebCore/Modules/applepay/PaymentMerchantSession.h (223793 => 223794)
--- trunk/Source/WebCore/Modules/applepay/PaymentMerchantSession.h 2017-10-20 20:58:09 UTC (rev 223793)
+++ trunk/Source/WebCore/Modules/applepay/PaymentMerchantSession.h 2017-10-20 20:58:49 UTC (rev 223794)
@@ -41,19 +41,12 @@
class PaymentMerchantSession {
public:
- PaymentMerchantSession()
- {
- }
-
+ PaymentMerchantSession() = default;
explicit PaymentMerchantSession(PKPaymentMerchantSession *pkPaymentMerchantSession)
: m_pkPaymentMerchantSession(pkPaymentMerchantSession)
{
}
- ~PaymentMerchantSession()
- {
- }
-
static std::optional<PaymentMerchantSession> fromJS(JSC::ExecState&, JSC::JSValue, String& errorMessage);
PKPaymentMerchantSession *pkPaymentMerchantSession() const { return m_pkPaymentMerchantSession.get(); }
Modified: trunk/Source/WebCore/platform/ControlStates.h (223793 => 223794)
--- trunk/Source/WebCore/platform/ControlStates.h 2017-10-20 20:58:09 UTC (rev 223793)
+++ trunk/Source/WebCore/platform/ControlStates.h 2017-10-20 20:58:49 UTC (rev 223794)
@@ -64,10 +64,6 @@
{
}
- ~ControlStates()
- {
- }
-
States states() const { return m_states; }
void setStates(States newStates)
{
Modified: trunk/Source/WebCore/platform/PlatformEvent.h (223793 => 223794)
--- trunk/Source/WebCore/platform/PlatformEvent.h 2017-10-20 20:58:09 UTC (rev 223793)
+++ trunk/Source/WebCore/platform/PlatformEvent.h 2017-10-20 20:58:49 UTC (rev 223794)
@@ -123,9 +123,7 @@
// Explicit protected destructor so that people don't accidentally
// delete a PlatformEvent.
- ~PlatformEvent()
- {
- }
+ ~PlatformEvent() = default;
unsigned m_type;
OptionSet<Modifier> m_modifiers;
Modified: trunk/Source/WebCore/platform/PlatformStrategies.h (223793 => 223794)
--- trunk/Source/WebCore/platform/PlatformStrategies.h 2017-10-20 20:58:09 UTC (rev 223793)
+++ trunk/Source/WebCore/platform/PlatformStrategies.h 2017-10-20 20:58:49 UTC (rev 223794)
@@ -63,9 +63,7 @@
}
protected:
- PlatformStrategies()
- {
- }
+ PlatformStrategies() = default;
virtual ~PlatformStrategies()
{
Modified: trunk/Source/WebCore/platform/image-decoders/gif/GIFImageReader.h (223793 => 223794)
--- trunk/Source/WebCore/platform/image-decoders/gif/GIFImageReader.h 2017-10-20 20:58:09 UTC (rev 223793)
+++ trunk/Source/WebCore/platform/image-decoders/gif/GIFImageReader.h 2017-10-20 20:58:49 UTC (rev 223794)
@@ -188,10 +188,6 @@
, m_isDataSizeDefined(false)
{
}
-
- ~GIFFrameContext()
- {
- }
void addLzwBlock(size_t position, size_t size)
{
@@ -241,10 +237,6 @@
{
}
- ~GIFImageReader()
- {
- }
-
void setData(WebCore::SharedBuffer* data) { m_data = data; }
// FIXME: haltAtFrame should be size_t.
bool decode(WebCore::GIFImageDecoder::GIFQuery, unsigned haltAtFrame);
Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.h (223793 => 223794)
--- trunk/Source/WebCore/rendering/RenderBlockFlow.h 2017-10-20 20:58:09 UTC (rev 223793)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.h 2017-10-20 20:58:49 UTC (rev 223794)
@@ -124,10 +124,6 @@
{
}
- ~RenderBlockFlowRareData()
- {
- }
-
static LayoutUnit positiveMarginBeforeDefault(const RenderBlock& block)
{
return std::max<LayoutUnit>(block.marginBefore(), 0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
