Title: [223890] trunk/Source/WebKit
- Revision
- 223890
- Author
- commit-qu...@webkit.org
- Date
- 2017-10-24 09:33:16 -0700 (Tue, 24 Oct 2017)
Log Message
ASSERTION FAILED: !m_serviceWorkerManager in WebProcess::getWorkerContextConnection() on API tests
https://bugs.webkit.org/show_bug.cgi?id=178586
<rdar://problem/35115902>
Patch by Youenn Fablet <you...@apple.com> on 2017-10-24
Reviewed by Brady Eidson.
Covered by API tests no longer crashing.
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getWorkerContextProcessConnection): Sending a worker context process connection message only at creation of the service worker process.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (223889 => 223890)
--- trunk/Source/WebKit/ChangeLog 2017-10-24 16:21:36 UTC (rev 223889)
+++ trunk/Source/WebKit/ChangeLog 2017-10-24 16:33:16 UTC (rev 223890)
@@ -1,3 +1,16 @@
+2017-10-24 Youenn Fablet <you...@apple.com>
+
+ ASSERTION FAILED: !m_serviceWorkerManager in WebProcess::getWorkerContextConnection() on API tests
+ https://bugs.webkit.org/show_bug.cgi?id=178586
+ <rdar://problem/35115902>
+
+ Reviewed by Brady Eidson.
+
+ Covered by API tests no longer crashing.
+
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::getWorkerContextProcessConnection): Sending a worker context process connection message only at creation of the service worker process.
+
2017-10-24 Brent Fulgham <bfulg...@apple.com>
Adopt new secure coding APIs
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (223889 => 223890)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-10-24 16:21:36 UTC (rev 223889)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-10-24 16:33:16 UTC (rev 223890)
@@ -589,13 +589,13 @@
{
ASSERT_UNUSED(proxy, &proxy == m_storageProcess);
- if (!m_workerContextProcess) {
- if (!m_websiteDataStore)
- m_websiteDataStore = API::WebsiteDataStore::defaultDataStore().ptr();
- auto& newProcess = createNewWebProcess(m_websiteDataStore->websiteDataStore());
- m_workerContextProcess = &newProcess;
- }
-
+ if (m_workerContextProcess)
+ return;
+
+ if (!m_websiteDataStore)
+ m_websiteDataStore = API::WebsiteDataStore::defaultDataStore().ptr();
+ auto& newProcess = createNewWebProcess(m_websiteDataStore->websiteDataStore());
+ m_workerContextProcess = &newProcess;
m_workerContextProcess->send(Messages::WebProcess::GetWorkerContextConnection(), 0);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
