Title: [223899] trunk/LayoutTests
Revision
223899
Author
[email protected]
Date
2017-10-24 11:04:37 -0700 (Tue, 24 Oct 2017)

Log Message

Unreviewed test gardening. Improved attempt to reduce flakiness of inspector/network/har tests.

* http/tests/inspector/network/har/har-page-expected.txt:
* http/tests/inspector/network/har/har-page.html:
Earlier filters were taking affect, so move these checks up.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (223898 => 223899)


--- trunk/LayoutTests/ChangeLog	2017-10-24 17:50:19 UTC (rev 223898)
+++ trunk/LayoutTests/ChangeLog	2017-10-24 18:04:37 UTC (rev 223899)
@@ -1,3 +1,11 @@
+2017-10-24  Joseph Pecoraro  <[email protected]>
+
+        Unreviewed test gardening. Improved attempt to reduce flakiness of inspector/network/har tests.
+
+        * http/tests/inspector/network/har/har-page-expected.txt:
+        * http/tests/inspector/network/har/har-page.html:
+        Earlier filters were taking affect, so move these checks up.
+
 2017-10-24  Antti Koivisto  <[email protected]>
 
         Create inline wrappers for before/after pseudo elements that have display:contents

Modified: trunk/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt (223898 => 223899)


--- trunk/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt	2017-10-24 17:50:19 UTC (rev 223898)
+++ trunk/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt	2017-10-24 18:04:37 UTC (rev 223899)
@@ -43,15 +43,14 @@
           "cookies": [],
           "headers": "<filtered>",
           "content": {
-            "size": 3044,
+            "size": 2923,
             "compression": 0,
             "mimeType": "text/html",
-            "text": "<filtered text (3044)>"
+            "text": "<filtered text (2923)>"
           },
           "redirectURL": "",
           "headersSize": "<filtered>",
-          "bodySize": "<filtered>",
-          "_transferSize": "<filtered>"
+          "bodySize": "<filtered>"
         },
         "cache": {},
         "timings": {
@@ -62,8 +61,7 @@
           "send": "<filtered>",
           "wait": "<filtered>",
           "receive": "<filtered>"
-        },
-        "connection": "<filtered>"
+        }
       },
       {
         "pageref": "page_0",
@@ -93,8 +91,7 @@
           },
           "redirectURL": "",
           "headersSize": "<filtered>",
-          "bodySize": "<filtered>",
-          "_transferSize": "<filtered>"
+          "bodySize": "<filtered>"
         },
         "cache": {},
         "timings": {

Modified: trunk/LayoutTests/http/tests/inspector/network/har/har-page.html (223898 => 223899)


--- trunk/LayoutTests/http/tests/inspector/network/har/har-page.html	2017-10-24 17:50:19 UTC (rev 223898)
+++ trunk/LayoutTests/http/tests/inspector/network/har/har-page.html	2017-10-24 18:04:37 UTC (rev 223899)
@@ -13,6 +13,16 @@
             return value;
         }
 
+        // Cache may or may not have been used so remove optional fields which may or may not be set.
+        if (key === "connection")
+            return undefined;
+        if (key === "serverIPAddress")
+            return undefined;
+        if (key === "_transferSize")
+            return undefined;
+        if (key === "_fetchType")
+            return undefined;
+
         // Headers include dynamic data.
         if (key === "headers")
             return "<filtered>";
@@ -25,24 +35,10 @@
         if (key.endsWith("Size"))
             return "<filtered>";
 
-        // Connection identifier could be different.
-        if (key === "connection")
-            return "<filtered>";
-
         // Reduce the file contents.
         if (key === "text")
             return "<filtered text (" + value.length + ")>";
 
-        // Cache may or may not have been used so remove optional fields which may or may not be set.
-        if (key === "connection")
-            return undefined;
-        if (key === "serverIPAddress")
-            return undefined;
-        if (key === "_transferSize")
-            return undefined;
-        if (key === "_fetchType")
-            return undefined;        
-
         // Since cache may or may not be used, timing data may be variable.
         // NOTE: SSL should always be -1 for this test case.
         if (key === "time")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to