Title: [223931] trunk/Source/WebInspectorUI
- Revision
- 223931
- Author
- [email protected]
- Date
- 2017-10-24 15:11:59 -0700 (Tue, 24 Oct 2017)
Log Message
Web Inspector: Console Drawer resizing doesn't match cursor position
https://bugs.webkit.org/show_bug.cgi?id=178753
<rdar://problem/35160484>
Reviewed by Brian Burg.
* UserInterface/Views/ConsoleDrawer.js:
(WI.ConsoleDrawer.prototype._updateDrawerHeight):
Drive-by fix an early return that would never have worked.
* UserInterface/Views/Main.css:
(#content):
Give the #content a flex grow of 1. This causes the space to grow as it
already was but now it does not affect the size of the fixed height sibling.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (223930 => 223931)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-24 22:05:30 UTC (rev 223930)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-24 22:11:59 UTC (rev 223931)
@@ -1,3 +1,20 @@
+2017-10-24 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Console Drawer resizing doesn't match cursor position
+ https://bugs.webkit.org/show_bug.cgi?id=178753
+ <rdar://problem/35160484>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/ConsoleDrawer.js:
+ (WI.ConsoleDrawer.prototype._updateDrawerHeight):
+ Drive-by fix an early return that would never have worked.
+
+ * UserInterface/Views/Main.css:
+ (#content):
+ Give the #content a flex grow of 1. This causes the space to grow as it
+ already was but now it does not affect the size of the fixed height sibling.
+
2017-10-24 Eric Carlson <[email protected]>
Web Inspector: Enable WebKit logging configuration and display
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js (223930 => 223931)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js 2017-10-24 22:05:30 UTC (rev 223930)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js 2017-10-24 22:11:59 UTC (rev 223931)
@@ -147,11 +147,11 @@
const minimumHeight = 64;
const maximumHeight = this.element.parentNode.offsetHeight - 100;
- height = Number.constrain(height, minimumHeight, maximumHeight);
- if (height === this.element.style.height)
+ let heightCSSValue = Number.constrain(height, minimumHeight, maximumHeight) + "px";
+ if (this.element.style.height === heightCSSValue)
return;
- this.element.style.height = height + "px";
+ this.element.style.height = heightCSSValue;
this.dispatchEventToListeners(WI.ConsoleDrawer.Event.Resized);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (223930 => 223931)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2017-10-24 22:05:30 UTC (rev 223930)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2017-10-24 22:11:59 UTC (rev 223931)
@@ -151,6 +151,7 @@
#content {
display: flex;
height: 100%; /* This reduces paint areas when typing in the console. http://webkit.org/b/145324 */
+ flex: 1;
}
#tab-browser {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
