Title: [223934] trunk
- Revision
- 223934
- Author
- [email protected]
- Date
- 2017-10-24 15:23:12 -0700 (Tue, 24 Oct 2017)
Log Message
Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
https://bugs.webkit.org/show_bug.cgi?id=174267
Reviewed by Tim Horton.
Source/WebKit:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanHandleRequest):
Tools:
* TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:
(TestWebKitAPI::runTest):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (223933 => 223934)
--- trunk/Source/WebKit/ChangeLog 2017-10-24 22:20:59 UTC (rev 223933)
+++ trunk/Source/WebKit/ChangeLog 2017-10-24 22:23:12 UTC (rev 223934)
@@ -1,3 +1,13 @@
+2017-10-24 Alex Christensen <[email protected]>
+
+ Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
+ https://bugs.webkit.org/show_bug.cgi?id=174267
+
+ Reviewed by Tim Horton.
+
+ * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+ (WKBundlePageCanHandleRequest):
+
2017-10-24 Chris Dumez <[email protected]>
Add initial implementation for serviceWorker.postMessage()
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (223933 => 223934)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2017-10-24 22:20:59 UTC (rev 223933)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2017-10-24 22:23:12 UTC (rev 223934)
@@ -422,6 +422,8 @@
bool WKBundlePageCanHandleRequest(WKURLRequestRef requestRef)
{
+ if (!requestRef)
+ return false;
return WebPage::canHandleRequest(toImpl(requestRef)->resourceRequest());
}
Modified: trunk/Tools/ChangeLog (223933 => 223934)
--- trunk/Tools/ChangeLog 2017-10-24 22:20:59 UTC (rev 223933)
+++ trunk/Tools/ChangeLog 2017-10-24 22:23:12 UTC (rev 223934)
@@ -1,3 +1,13 @@
+2017-10-24 Alex Christensen <[email protected]>
+
+ Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
+ https://bugs.webkit.org/show_bug.cgi?id=174267
+
+ Reviewed by Tim Horton.
+
+ * TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:
+ (TestWebKitAPI::runTest):
+
2017-10-24 Eric Carlson <[email protected]>
Web Inspector: Enable WebKit logging configuration and display
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp (223933 => 223934)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp 2017-10-24 22:20:59 UTC (rev 223933)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp 2017-10-24 22:23:12 UTC (rev 223934)
@@ -56,7 +56,7 @@
static bool runTest()
{
- return canHandleURL("about:blank") && canHandleURL("emptyscheme://") && !canHandleURL("notascheme://");
+ return !WKBundlePageCanHandleRequest(nullptr) && canHandleURL("about:blank") && canHandleURL("emptyscheme://") && !canHandleURL("notascheme://");
}
void CanHandleRequestTest::didReceiveMessage(WKBundleRef bundle, WKStringRef messageName, WKTypeRef)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
