Title: [223937] trunk/Source/_javascript_Core
Revision
223937
Author
[email protected]
Date
2017-10-24 15:59:51 -0700 (Tue, 24 Oct 2017)

Log Message

Allow OjbC Weak References when building TestAPI
https://bugs.webkit.org/show_bug.cgi?id=178748

Reviewed by Dan Bernstein.

Set TestAPI build flag Weak References in Manual Retain Release to true.

* _javascript_Core.xcodeproj/project.pbxproj: Reverted.
* Configurations/ToolExecutable.xcconfig: Changed the flag here instead.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (223936 => 223937)


--- trunk/Source/_javascript_Core/ChangeLog	2017-10-24 22:30:15 UTC (rev 223936)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-10-24 22:59:51 UTC (rev 223937)
@@ -1,3 +1,15 @@
+2017-10-24  Michael Saboff  <[email protected]>
+
+        Allow OjbC Weak References when building TestAPI
+        https://bugs.webkit.org/show_bug.cgi?id=178748
+
+        Reviewed by Dan Bernstein.
+
+        Set TestAPI build flag Weak References in Manual Retain Release to true.
+
+        * _javascript_Core.xcodeproj/project.pbxproj: Reverted.
+        * Configurations/ToolExecutable.xcconfig: Changed the flag here instead.
+
 2017-10-24  Eric Carlson  <[email protected]>
 
         Web Inspector: Enable WebKit logging configuration and display

Modified: trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig (223936 => 223937)


--- trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2017-10-24 22:30:15 UTC (rev 223936)
+++ trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig	2017-10-24 22:59:51 UTC (rev 223937)
@@ -51,6 +51,8 @@
 CLANG_ENABLE_OBJC_ARC_arm64 = YES;
 CLANG_ENABLE_OBJC_ARC_arm64e = YES;
 
+CLANG_ENABLE_OBJC_WEAK = YES;
+
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
 

Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (223936 => 223937)


--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2017-10-24 22:30:15 UTC (rev 223936)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2017-10-24 22:59:51 UTC (rev 223937)
@@ -10383,7 +10383,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				CLANG_ENABLE_OBJC_WEAK = YES;
 			};
 			name = Debug;
 		};
@@ -10391,7 +10390,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				CLANG_ENABLE_OBJC_WEAK = YES;
 			};
 			name = Release;
 		};
@@ -10399,7 +10397,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				CLANG_ENABLE_OBJC_WEAK = YES;
 			};
 			name = Production;
 		};
@@ -10588,7 +10585,6 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
 			buildSettings = {
-				CLANG_ENABLE_OBJC_WEAK = YES;
 			};
 			name = Profiling;
 		};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to