Title: [223940] trunk/Source/WebCore
Revision
223940
Author
[email protected]
Date
2017-10-24 17:12:28 -0700 (Tue, 24 Oct 2017)

Log Message

Fix Windows build after r223929.
https://bugs.webkit.org/show_bug.cgi?id=177027

* inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::getLoggingChannels):
Always initialize the variable "level".  Visual studio was complaining about the possibility of not initializing it
but this is only possible if logChannel->level is an invalid enum value.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (223939 => 223940)


--- trunk/Source/WebCore/ChangeLog	2017-10-25 00:09:35 UTC (rev 223939)
+++ trunk/Source/WebCore/ChangeLog	2017-10-25 00:12:28 UTC (rev 223940)
@@ -1,5 +1,15 @@
 2017-10-24  Alex Christensen  <[email protected]>
 
+        Fix Windows build after r223929.
+        https://bugs.webkit.org/show_bug.cgi?id=177027
+
+        * inspector/WebConsoleAgent.cpp:
+        (WebCore::WebConsoleAgent::getLoggingChannels):
+        Always initialize the variable "level".  Visual studio was complaining about the possibility of not initializing it
+        but this is only possible if logChannel->level is an invalid enum value.
+
+2017-10-24  Alex Christensen  <[email protected]>
+
         Fix Windows build after r223925
         https://bugs.webkit.org/show_bug.cgi?id=178687
 

Modified: trunk/Source/WebCore/inspector/WebConsoleAgent.cpp (223939 => 223940)


--- trunk/Source/WebCore/inspector/WebConsoleAgent.cpp	2017-10-25 00:09:35 UTC (rev 223939)
+++ trunk/Source/WebCore/inspector/WebConsoleAgent.cpp	2017-10-25 00:12:28 UTC (rev 223940)
@@ -65,10 +65,8 @@
         if (!logChannel)
             return;
 
-        Inspector::Protocol::Console::ChannelLevel level;
-        if (logChannel->state == WTFLogChannelOff)
-            level = Inspector::Protocol::Console::ChannelLevel::Off;
-        else {
+        Inspector::Protocol::Console::ChannelLevel level = Inspector::Protocol::Console::ChannelLevel::Off;
+        if (logChannel->state != WTFLogChannelOff)
             switch (logChannel->level) {
             case WTFLogLevelAlways:
                 level = Inspector::Protocol::Console::ChannelLevel::Log;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to