Diff
Modified: trunk/LayoutTests/ChangeLog (223981 => 223982)
--- trunk/LayoutTests/ChangeLog 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/ChangeLog 2017-10-25 21:19:19 UTC (rev 223982)
@@ -1,3 +1,18 @@
+2017-10-25 Alex Christensen <[email protected]>
+
+ LayoutTest http/tests/loading/basic-credentials-sent-automatically.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=159427
+
+ Reviewed by Youenn Fablet.
+
+ Use setTimeout to make load delegate callback printing more deterministic.
+ The important part is that the credentials are printed, and they still are.
+
+ * http/tests/loading/basic-credentials-sent-automatically-expected.txt:
+ * http/tests/loading/basic-credentials-sent-automatically.html:
+ * platform/mac/TestExpectations:
+ * platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
+
2017-10-25 Youenn Fablet <[email protected]>
Enable ServiceWorker to fetch resources
Modified: trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt (223981 => 223982)
--- trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt 2017-10-25 21:19:19 UTC (rev 223982)
@@ -1,30 +1,30 @@
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didHandleOnloadEventsForFrame
http://127.0.0.1:8000/loading/resources/subresources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with first:first-pw
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
http://127.0.0.1:8000/loading/resources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with second:second-pw
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame2-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame2-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame2-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame2-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame3-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame3-->-->" - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame3-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame3-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.
It will be authorized with first/first-pw.
Modified: trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html (223981 => 223982)
--- trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html 2017-10-25 21:19:19 UTC (rev 223982)
@@ -18,7 +18,7 @@
}
var frame = document.createElement("iframe");
frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/protected-resource.php");
- frame.setAttribute("onload", "secondFrameLoaded()");
+ frame.setAttribute("onload", "setTimeout(secondFrameLoaded, 0)");
document.body.appendChild(frame);
}
@@ -30,7 +30,7 @@
}
var frame = document.createElement("iframe");
frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/protected-resource.php");
- frame.setAttribute("onload", "thirdFrameLoaded()");
+ frame.setAttribute("onload", "setTimeout(thirdFrameLoaded, 0)");
document.body.appendChild(frame);
}
@@ -42,7 +42,7 @@
}
var frame = document.createElement("iframe");
frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/othersubresources/protected-resource.php");
- frame.setAttribute("onload", "fourthFrameLoaded()");
+ frame.setAttribute("onload", "setTimeout(fourthFrameLoaded, 0)");
document.body.appendChild(frame);
}
@@ -54,7 +54,7 @@
function makeIFrame() {
var iframe = document.createElement("iframe");
- iframe._onload_=firstFrameLoaded;
+ iframe.setAttribute("onload", "setTimeout(firstFrameLoaded, 0)");
iframe.src=""
document.body.appendChild(iframe);
}
@@ -61,7 +61,7 @@
</script>
</head>
-<body _onload_="makeIFrame()">
+<body _onload_="setTimeout(makeIFrame, 0)">
This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.<br>
The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.<br>
It will be authorized with first/first-pw.<br>
Modified: trunk/LayoutTests/platform/mac/TestExpectations (223981 => 223982)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-10-25 21:19:19 UTC (rev 223982)
@@ -1788,5 +1788,3 @@
webkit.org/b/178190 imported/w3c/web-platform-tests/XMLHttpRequest/open-url-worker-origin.htm [ Pass Failure ]
webkit.org/b/178465 [ Debug ] fast/html/marquee-reparent-check.html [ Skip ]
-
-webkit.org/b/159427 http/tests/loading/basic-credentials-sent-automatically.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt (223981 => 223982)
--- trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt 2017-10-25 21:19:19 UTC (rev 223982)
@@ -1,30 +1,30 @@
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didHandleOnloadEventsForFrame
127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with first:first-pw
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with second:second-pw
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame2-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame2-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame2-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame2-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame2-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame3-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame3-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame3-->-->" - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame3-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame3-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.
It will be authorized with first/first-pw.
