Title: [224042] trunk/LayoutTests
Revision
224042
Author
[email protected]
Date
2017-10-26 13:17:36 -0700 (Thu, 26 Oct 2017)

Log Message

http/tests/workers/service/service-worker-cache-api.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=178877

Patch by Youenn Fablet <[email protected]> on 2017-10-26
Reviewed by Alex Christensen.

Marking test as PASS/FAIL.
Changing test to finish after 10 seconds.
Beefing up logging to help identifiying flakiness reason.

* TestExpectations:
* http/tests/workers/service/resources/service-worker-cache-api-worker.js:
(event.event.respondWith.promise.then):
* http/tests/workers/service/resources/service-worker-cache-api.js:
(async.test):
* http/tests/workers/service/service-worker-cache-api.https-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (224041 => 224042)


--- trunk/LayoutTests/ChangeLog	2017-10-26 20:14:40 UTC (rev 224041)
+++ trunk/LayoutTests/ChangeLog	2017-10-26 20:17:36 UTC (rev 224042)
@@ -1,3 +1,21 @@
+2017-10-26  Youenn Fablet  <[email protected]>
+
+        http/tests/workers/service/service-worker-cache-api.https.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=178877
+
+        Reviewed by Alex Christensen.
+
+        Marking test as PASS/FAIL.
+        Changing test to finish after 10 seconds.
+        Beefing up logging to help identifiying flakiness reason.
+
+        * TestExpectations:
+        * http/tests/workers/service/resources/service-worker-cache-api-worker.js:
+        (event.event.respondWith.promise.then):
+        * http/tests/workers/service/resources/service-worker-cache-api.js:
+        (async.test):
+        * http/tests/workers/service/service-worker-cache-api.https-expected.txt:
+
 2017-10-26  Matt Lewis  <[email protected]>
 
         Marked webrtc/video-mute.html as flaky.

Modified: trunk/LayoutTests/TestExpectations (224041 => 224042)


--- trunk/LayoutTests/TestExpectations	2017-10-26 20:14:40 UTC (rev 224041)
+++ trunk/LayoutTests/TestExpectations	2017-10-26 20:17:36 UTC (rev 224042)
@@ -142,6 +142,8 @@
 imported/w3c/web-platform-tests/service-workers/cache-storage [ Pass ]
 imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker [ Skip ]
 
+http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
+
 # textarea.animate is not supported
 imported/w3c/web-platform-tests/css/css-ui-3/caret-color-018.html [ Skip ]
 imported/w3c/web-platform-tests/css/css-ui-3/caret-color-019.html [ Skip ]

Modified: trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api-worker.js (224041 => 224042)


--- trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api-worker.js	2017-10-26 20:14:40 UTC (rev 224041)
+++ trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api-worker.js	2017-10-26 20:17:36 UTC (rev 224042)
@@ -29,9 +29,13 @@
         return;
     }
     event.respondWith(promise.then(() => {
-        status = event.request.url.substring(0, event.request.url.length - 18);
+        status = "opening cache for " + event.request.url.substring(0, event.request.url.length - 18);
         return caches.open("test").then((cache) => {
+            status = "matching cache for " + event.request.url.substring(0, event.request.url.length - 18);
             return cache.match(event.request.url.substring(0, event.request.url.length - 18));
+        }).then((response) => {
+            status = "matched cache for " + event.request.url.substring(0, event.request.url.length - 18);
+            return response;
         });
     }));
 });

Modified: trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api.js (224041 => 224042)


--- trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api.js	2017-10-26 20:14:40 UTC (rev 224041)
+++ trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api.js	2017-10-26 20:17:36 UTC (rev 224042)
@@ -11,11 +11,15 @@
 
 async function test()
 {
+    setTimeout(finishSWTest, 10000);
     try {
+        log("Registering service worker");
         await navigator.serviceWorker.register("resources/service-worker-cache-api-worker.js", { });
+        log("Service worker registered");
 
         await logStatus();
 
+        log("Fetching");
         var response = await fetch("/resources/square100.png.fromserviceworker");
         var buffer =  await response.arrayBuffer();
         log("Response buffer byte length is " + buffer.byteLength);

Modified: trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https-expected.txt (224041 => 224042)


--- trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https-expected.txt	2017-10-26 20:14:40 UTC (rev 224041)
+++ trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https-expected.txt	2017-10-26 20:17:36 UTC (rev 224042)
@@ -1,4 +1,7 @@
+Registering service worker
+Service worker registered
 Status is cache is ready
+Fetching
 Response buffer byte length is 12940
-Status is https://127.0.0.1:8443/resources/square100.png
+Status is matched cache for https://127.0.0.1:8443/resources/square100.png
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to