Title: [224045] trunk/Source/WebCore
- Revision
- 224045
- Author
- [email protected]
- Date
- 2017-10-26 13:22:39 -0700 (Thu, 26 Oct 2017)
Log Message
Remove FrameView::serviceScriptedAnimations and Document::serviceScriptedAnimations
https://bugs.webkit.org/show_bug.cgi?id=178879
Patch by Antoine Quint <[email protected]> on 2017-10-26
Reviewed by Dean Jackson.
There are no call sites for FrameView::serviceScriptedAnimations() and that method is the
only call site for Document::serviceScriptedAnimations(), so both can go.
* dom/Document.cpp:
(WebCore::Document::serviceScriptedAnimations): Deleted.
* dom/Document.h:
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations): Deleted.
* page/FrameView.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (224044 => 224045)
--- trunk/Source/WebCore/ChangeLog 2017-10-26 20:22:13 UTC (rev 224044)
+++ trunk/Source/WebCore/ChangeLog 2017-10-26 20:22:39 UTC (rev 224045)
@@ -1,3 +1,20 @@
+2017-10-26 Antoine Quint <[email protected]>
+
+ Remove FrameView::serviceScriptedAnimations and Document::serviceScriptedAnimations
+ https://bugs.webkit.org/show_bug.cgi?id=178879
+
+ Reviewed by Dean Jackson.
+
+ There are no call sites for FrameView::serviceScriptedAnimations() and that method is the
+ only call site for Document::serviceScriptedAnimations(), so both can go.
+
+ * dom/Document.cpp:
+ (WebCore::Document::serviceScriptedAnimations): Deleted.
+ * dom/Document.h:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::serviceScriptedAnimations): Deleted.
+ * page/FrameView.h:
+
2017-10-26 Chris Dumez <[email protected]>
Bring back SWContextManager abstraction in WebCore
Modified: trunk/Source/WebCore/dom/Document.cpp (224044 => 224045)
--- trunk/Source/WebCore/dom/Document.cpp 2017-10-26 20:22:13 UTC (rev 224044)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-10-26 20:22:39 UTC (rev 224045)
@@ -6379,13 +6379,6 @@
m_scriptedAnimationController->cancelCallback(id);
}
-void Document::serviceScriptedAnimations(double timestamp)
-{
- if (!m_scriptedAnimationController)
- return;
- m_scriptedAnimationController->serviceScriptedAnimations(timestamp);
-}
-
void Document::clearScriptedAnimationController()
{
// FIXME: consider using ActiveDOMObject.
Modified: trunk/Source/WebCore/dom/Document.h (224044 => 224045)
--- trunk/Source/WebCore/dom/Document.h 2017-10-26 20:22:13 UTC (rev 224044)
+++ trunk/Source/WebCore/dom/Document.h 2017-10-26 20:22:39 UTC (rev 224045)
@@ -1146,7 +1146,6 @@
int requestAnimationFrame(Ref<RequestAnimationFrameCallback>&&);
void cancelAnimationFrame(int id);
- void serviceScriptedAnimations(double timestamp);
EventTarget* errorEventTarget() final;
void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, RefPtr<Inspector::ScriptCallStack>&&) final;
Modified: trunk/Source/WebCore/page/FrameView.cpp (224044 => 224045)
--- trunk/Source/WebCore/page/FrameView.cpp 2017-10-26 20:22:13 UTC (rev 224044)
+++ trunk/Source/WebCore/page/FrameView.cpp 2017-10-26 20:22:39 UTC (rev 224045)
@@ -3192,25 +3192,6 @@
scheduleRelayout();
}
-void FrameView::serviceScriptedAnimations()
-{
- for (auto* frame = m_frame.ptr(); frame; frame = frame->tree().traverseNext()) {
- frame->view()->serviceScrollAnimations();
- frame->animation().serviceAnimations();
- }
-
- if (!frame().document() || !frame().document()->domWindow())
- return;
-
- Vector<RefPtr<Document>> documents;
- for (auto* frame = m_frame.ptr(); frame; frame = frame->tree().traverseNext())
- documents.append(frame->document());
-
- double timestamp = frame().document()->domWindow()->nowTimestamp();
- for (auto& document : documents)
- document->serviceScriptedAnimations(timestamp);
-}
-
bool FrameView::isTransparent() const
{
return m_isTransparent;
Modified: trunk/Source/WebCore/page/FrameView.h (224044 => 224045)
--- trunk/Source/WebCore/page/FrameView.h 2017-10-26 20:22:13 UTC (rev 224044)
+++ trunk/Source/WebCore/page/FrameView.h 2017-10-26 20:22:39 UTC (rev 224045)
@@ -144,8 +144,6 @@
bool useCustomFixedPositionLayoutRect() const { return false; }
#endif
- WEBCORE_EXPORT void serviceScriptedAnimations();
-
void willRecalcStyle();
bool updateCompositingLayersAfterStyleChange();
void updateCompositingLayersAfterLayout();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
