Title: [224047] trunk
- Revision
- 224047
- Author
- [email protected]
- Date
- 2017-10-26 13:57:08 -0700 (Thu, 26 Oct 2017)
Log Message
[WPE] Use proper shared object versioning for libWPEWebKit.so
https://bugs.webkit.org/show_bug.cgi?id=178878
Reviewed by Michael Catanzaro.
Move the CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE() to a new CMake include file,
and use it both for the GTK+ and WPE ports. Also add a SET_PROJECT_VERSION() macro to
unify setting the PROJECT_VERSION* family of variables.
* Source/cmake/OptionsGTK.cmake: Use the common macros imported from VersioningUtils.cmake.
* Source/cmake/OptionsWPE.cmake: Properly assign a shared object version to libWPEWebKit.so,
using the common macros from VersioningUtils.cmake.
* Source/cmake/VersioningUtils.cmake: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/ChangeLog (224046 => 224047)
--- trunk/ChangeLog 2017-10-26 20:45:21 UTC (rev 224046)
+++ trunk/ChangeLog 2017-10-26 20:57:08 UTC (rev 224047)
@@ -1,5 +1,21 @@
2017-10-26 Adrian Perez de Castro <[email protected]>
+ [WPE] Use proper shared object versioning for libWPEWebKit.so
+ https://bugs.webkit.org/show_bug.cgi?id=178878
+
+ Reviewed by Michael Catanzaro.
+
+ Move the CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE() to a new CMake include file,
+ and use it both for the GTK+ and WPE ports. Also add a SET_PROJECT_VERSION() macro to
+ unify setting the PROJECT_VERSION* family of variables.
+
+ * Source/cmake/OptionsGTK.cmake: Use the common macros imported from VersioningUtils.cmake.
+ * Source/cmake/OptionsWPE.cmake: Properly assign a shared object version to libWPEWebKit.so,
+ using the common macros from VersioningUtils.cmake.
+ * Source/cmake/VersioningUtils.cmake: Added.
+
+2017-10-26 Adrian Perez de Castro <[email protected]>
+
[GTK] WebKit library .so version is not being set correctly
https://bugs.webkit.org/show_bug.cgi?id=178873
Modified: trunk/Source/cmake/OptionsGTK.cmake (224046 => 224047)
--- trunk/Source/cmake/OptionsGTK.cmake 2017-10-26 20:45:21 UTC (rev 224046)
+++ trunk/Source/cmake/OptionsGTK.cmake 2017-10-26 20:57:08 UTC (rev 224047)
@@ -1,19 +1,9 @@
include(GNUInstallDirs)
+include(VersioningUtils)
-set(PROJECT_VERSION_MAJOR 2)
-set(PROJECT_VERSION_MINOR 19)
-set(PROJECT_VERSION_MICRO 0)
-set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_MICRO})
+SET_PROJECT_VERSION(2 19 0)
set(WEBKITGTK_API_VERSION 4.0)
-# Libtool library version, not to be confused with API version.
-# See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-macro(CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE library_name current revision age)
- math(EXPR ${library_name}_VERSION_MAJOR "${current} - ${age}")
- set(${library_name}_VERSION_MINOR ${age})
- set(${library_name}_VERSION_MICRO ${revision})
- set(${library_name}_VERSION ${${library_name}_VERSION_MAJOR}.${age}.${revision})
-endmacro()
CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 62 0 25)
CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 25 0 7)
Modified: trunk/Source/cmake/OptionsWPE.cmake (224046 => 224047)
--- trunk/Source/cmake/OptionsWPE.cmake 2017-10-26 20:45:21 UTC (rev 224046)
+++ trunk/Source/cmake/OptionsWPE.cmake 2017-10-26 20:57:08 UTC (rev 224047)
@@ -1,11 +1,11 @@
include(GNUInstallDirs)
+include(VersioningUtils)
-set(PROJECT_VERSION_MAJOR 0)
-set(PROJECT_VERSION_MINOR 0)
-set(PROJECT_VERSION_PATCH 20170728)
-set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH})
+SET_PROJECT_VERSION(0 19 0)
set(WPE_API_VERSION 0.1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 0 0)
+
WEBKIT_OPTION_BEGIN()
include(GStreamerDefinitions)
Added: trunk/Source/cmake/VersioningUtils.cmake (0 => 224047)
--- trunk/Source/cmake/VersioningUtils.cmake (rev 0)
+++ trunk/Source/cmake/VersioningUtils.cmake 2017-10-26 20:57:08 UTC (rev 224047)
@@ -0,0 +1,15 @@
+macro(SET_PROJECT_VERSION major minor micro)
+ set(PROJECT_VERSION_MAJOR "${major}")
+ set(PROJECT_VERSION_MINOR "${minor}")
+ set(PROJECT_VERSION_MICRO "${micro}")
+ set(PROJECT_VERSION "${major}.${minor}.${micro}")
+endmacro()
+
+# Libtool library version, not to be confused with API version.
+# See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
+macro(CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE library_name current revision age)
+ math(EXPR ${library_name}_VERSION_MAJOR "${current} - ${age}")
+ set(${library_name}_VERSION_MINOR ${age})
+ set(${library_name}_VERSION_MICRO ${revision})
+ set(${library_name}_VERSION ${${library_name}_VERSION_MAJOR}.${age}.${revision})
+endmacro()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
