Title: [224062] trunk/Source/WebCore
Revision
224062
Author
[email protected]
Date
2017-10-26 16:28:31 -0700 (Thu, 26 Oct 2017)

Log Message

[Payment Request] Restrict API use to secure, same-origin frames
https://bugs.webkit.org/show_bug.cgi?id=178887

Patch by Andy Estes <[email protected]> on 2017-10-26
Reviewed by Tim Horton.

Reuse the access checks from Apple Pay to restrict PaymentRequest API usage to secure frames
in the same origin as the main frame.

Progresses active-document-cross-origin.https.sub.html and
active-document-same-origin.https.html from web-platform-tests. Regresses basic.https.html
since the allowpaymentrequest <iframe> attribute is not yet implemented.

* Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::supportsVersion):
(WebCore::ApplePaySession::canMakePayments):
(WebCore::ApplePaySession::canMakePaymentsWithActiveCard):
(WebCore::ApplePaySession::openPaymentSetup):
(WebCore::isSecure): Deleted.
(WebCore::canCallApplePaySessionAPIs): Deleted.
* Modules/applepay/PaymentSession.cpp: Added.
(WebCore::isSecure):
(WebCore::PaymentSession::canCreateSession):
* Modules/applepay/PaymentSession.h:
* Modules/paymentrequest/PaymentHandler.cpp:
(WebCore::PaymentHandler::canCreateSession):
* Modules/paymentrequest/PaymentHandler.h:
* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::create):
* WebCore.xcodeproj/project.pbxproj:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (224061 => 224062)


--- trunk/Source/WebCore/ChangeLog	2017-10-26 23:25:41 UTC (rev 224061)
+++ trunk/Source/WebCore/ChangeLog	2017-10-26 23:28:31 UTC (rev 224062)
@@ -78,6 +78,12 @@
 
 2017-10-26  Keith Miller  <[email protected]>
 
+        Unreviewed, add deprecated declarations pragma to fix macosx.
+
+        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+
+2017-10-26  Keith Miller  <[email protected]>
+
         Unreviewed, iOS build fix.
 
         * SourcesMac.txt:

Modified: trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm (224061 => 224062)


--- trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm	2017-10-26 23:25:41 UTC (rev 224061)
+++ trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm	2017-10-26 23:28:31 UTC (rev 224062)
@@ -45,6 +45,9 @@
 #import <wtf/NeverDestroyed.h>
 #import <wtf/SoftLinking.h>
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 SOFT_LINK_FRAMEWORK(QTKit)
 
 SOFT_LINK(QTKit, QTMakeTime, QTTime, (long long timeValue, long timeScale), (timeValue, timeScale))
@@ -1719,4 +1722,6 @@
 
 @end
 
+#pragma clang diagnostic pop // deprecated-declarations
+
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to