Title: [224106] releases/WebKitGTK/webkit-2.18/Source/WebDriver
- Revision
- 224106
- Author
- [email protected]
- Date
- 2017-10-27 02:31:13 -0700 (Fri, 27 Oct 2017)
Log Message
Merge r224090 - WebDriver: unknown capabilities should produce an InvalidArgument error when validating capabilities
https://bugs.webkit.org/show_bug.cgi?id=178868
Reviewed by Brian Burg.
7.2 Processing Capabilities
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities
Fixes: imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_extensions
* WebDriverService.cpp:
(WebDriver::WebDriverService::validatedCapabilities const):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.18/Source/WebDriver/ChangeLog (224105 => 224106)
--- releases/WebKitGTK/webkit-2.18/Source/WebDriver/ChangeLog 2017-10-27 09:31:09 UTC (rev 224105)
+++ releases/WebKitGTK/webkit-2.18/Source/WebDriver/ChangeLog 2017-10-27 09:31:13 UTC (rev 224106)
@@ -1,5 +1,20 @@
2017-10-27 Carlos Garcia Campos <[email protected]>
+ WebDriver: unknown capabilities should produce an InvalidArgument error when validating capabilities
+ https://bugs.webkit.org/show_bug.cgi?id=178868
+
+ Reviewed by Brian Burg.
+
+ 7.2 Processing Capabilities
+ https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities
+
+ Fixes: imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py::test_invalid_extensions
+
+ * WebDriverService.cpp:
+ (WebDriver::WebDriverService::validatedCapabilities const):
+
+2017-10-27 Carlos Garcia Campos <[email protected]>
+
WebDriver: deserializeTimeouts should fail if the value is not integer
https://bugs.webkit.org/show_bug.cgi?id=178866
Modified: releases/WebKitGTK/webkit-2.18/Source/WebDriver/WebDriverService.cpp (224105 => 224106)
--- releases/WebKitGTK/webkit-2.18/Source/WebDriver/WebDriverService.cpp 2017-10-27 09:31:09 UTC (rev 224105)
+++ releases/WebKitGTK/webkit-2.18/Source/WebDriver/WebDriverService.cpp 2017-10-27 09:31:13 UTC (rev 224106)
@@ -404,7 +404,8 @@
if (!platformValidateCapability(it->key, it->value))
return nullptr;
result->setValue(it->key, RefPtr<InspectorValue>(it->value));
- }
+ } else
+ return nullptr;
}
return result;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
