Title: [224117] trunk/Tools
- Revision
- 224117
- Author
- [email protected]
- Date
- 2017-10-27 10:16:46 -0700 (Fri, 27 Oct 2017)
Log Message
NowPlayingInfo should contain a unique identifier
https://bugs.webkit.org/show_bug.cgi?id=178872
<rdar://problem/34924012>
Unreviewed, fix a flakey test.
* TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
(-[NowPlayingTestWebView hasActiveNowPlayingSession]): Update _lastUpdatedElapsedTime.
(-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (224116 => 224117)
--- trunk/Tools/ChangeLog 2017-10-27 17:06:17 UTC (rev 224116)
+++ trunk/Tools/ChangeLog 2017-10-27 17:16:46 UTC (rev 224117)
@@ -1,3 +1,15 @@
+2017-10-27 Eric Carlson <[email protected]>
+
+ NowPlayingInfo should contain a unique identifier
+ https://bugs.webkit.org/show_bug.cgi?id=178872
+ <rdar://problem/34924012>
+
+ Unreviewed, fix a flakey test.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
+ (-[NowPlayingTestWebView hasActiveNowPlayingSession]): Update _lastUpdatedElapsedTime.
+ (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.
+
2017-10-27 Fujii Hironori <[email protected]>
autoinstall can't download from http://pypi.python.org
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm (224116 => 224117)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm 2017-10-27 17:06:17 UTC (rev 224116)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm 2017-10-27 17:16:46 UTC (rev 224117)
@@ -53,6 +53,7 @@
_hasActiveNowPlayingSession = active;
_lastUpdatedTitle = [title copy];
_lastUpdatedDuration = duration;
+ _lastUpdatedElapsedTime = elapsedTime;
_lastUniqueIdentifier = uniqueIdentifier;
_receivedNowPlayingInfoResponse = true;
@@ -74,16 +75,6 @@
}
}
-- (void)_handleActiveNowPlayingSessionInfoResponse:(BOOL)hasActiveSession title:(NSString *)title duration:(double)duration elapsedTime:(double)elapsedTime
-{
- _hasActiveNowPlayingSession = hasActiveSession;
- _lastUpdatedTitle = [title copy];
- _lastUpdatedDuration = duration;
- _lastUpdatedElapsedTime = elapsedTime;
-
- _receivedNowPlayingInfoResponse = true;
-}
-
- (void)setWindowVisible:(BOOL)isVisible
{
#if PLATFORM(MAC)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
