Title: [224124] trunk/Tools
- Revision
- 224124
- Author
- [email protected]
- Date
- 2017-10-27 12:10:24 -0700 (Fri, 27 Oct 2017)
Log Message
Windows and WebViews are retained after re-configure
https://bugs.webkit.org/show_bug.cgi?id=178902
<rdar://problem/35211518>
Reviewed by Alexey Proskuryakov.
The test runner effectively leaks windows every time a test changes configuration.
We give each test it's own AutoreleasePool to fix this problem.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
so that when a configuration changes, the old window and WebView are released.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (224123 => 224124)
--- trunk/Tools/ChangeLog 2017-10-27 18:56:11 UTC (rev 224123)
+++ trunk/Tools/ChangeLog 2017-10-27 19:10:24 UTC (rev 224124)
@@ -1,3 +1,18 @@
+2017-10-27 Jonathan Bedard <[email protected]>
+
+ Windows and WebViews are retained after re-configure
+ https://bugs.webkit.org/show_bug.cgi?id=178902
+ <rdar://problem/35211518>
+
+ Reviewed by Alexey Proskuryakov.
+
+ The test runner effectively leaks windows every time a test changes configuration.
+ We give each test it's own AutoreleasePool to fix this problem.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
+ so that when a configuration changes, the old window and WebView are released.
+
2017-10-27 Eric Carlson <[email protected]>
NowPlayingInfo should contain a unique identifier
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (224123 => 224124)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2017-10-27 18:56:11 UTC (rev 224123)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2017-10-27 19:10:24 UTC (rev 224124)
@@ -67,6 +67,7 @@
#include <stdlib.h>
#include <string>
#include <unistd.h>
+#include <wtf/AutodrainedPool.h>
#include <wtf/CryptographicallyRandomNumber.h>
#include <wtf/HexNumber.h>
#include <wtf/MainThread.h>
@@ -1176,6 +1177,8 @@
bool TestController::runTest(const char* inputLine)
{
+ AutodrainedPool pool;
+
WKTextCheckerSetTestingMode(true);
TestCommand command = parseInputLine(std::string(inputLine));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
