Title: [100366] trunk/Source/WebCore
- Revision
- 100366
- Author
- [email protected]
- Date
- 2011-11-15 16:34:00 -0800 (Tue, 15 Nov 2011)
Log Message
Pointer Lock: Refactor: MouseEvent.idl movementX/Y
https://bugs.webkit.org/show_bug.cgi?id=72427
- [Conditional...] vs #if defined
- Runtime enabled
- .movementX/Y prefixed with 'webkit'
Reviewed by Adam Barth.
No new tests.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):
* dom/MouseEvent.idl:
* dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::webkitMovementX):
(WebCore::MouseRelatedEvent::webkitMovementY):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (100365 => 100366)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 00:34:00 UTC (rev 100366)
@@ -1,3 +1,24 @@
+2011-11-15 Vincent Scheib <[email protected]>
+
+ Pointer Lock: Refactor: MouseEvent.idl movementX/Y
+ https://bugs.webkit.org/show_bug.cgi?id=72427
+
+ - [Conditional...] vs #if defined
+ - Runtime enabled
+ - .movementX/Y prefixed with 'webkit'
+
+ Reviewed by Adam Barth.
+
+ No new tests.
+
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
+ (WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):
+ * dom/MouseEvent.idl:
+ * dom/MouseRelatedEvent.h:
+ (WebCore::MouseRelatedEvent::webkitMovementX):
+ (WebCore::MouseRelatedEvent::webkitMovementY):
+
2011-10-28 Ojan Vafai <[email protected]>
implement flex-align for flex-flow: column
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (100365 => 100366)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2011-11-16 00:34:00 UTC (rev 100366)
@@ -84,6 +84,8 @@
static bool webkitPointerLockEnabled() { return isPointerLockEnabled; }
static void setWebkitPointerLockEnabled(bool isEnabled) { isPointerLockEnabled = isEnabled; }
static bool webkitPointerEnabled() { return isPointerLockEnabled; }
+ static bool webkitMovementXEnabled() { return isPointerLockEnabled; }
+ static bool webkitMovementYEnabled() { return isPointerLockEnabled; }
#endif
#if ENABLE(VIDEO)
Modified: trunk/Source/WebCore/dom/MouseEvent.idl (100365 => 100366)
--- trunk/Source/WebCore/dom/MouseEvent.idl 2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/dom/MouseEvent.idl 2011-11-16 00:34:00 UTC (rev 100366)
@@ -25,10 +25,8 @@
readonly attribute long screenY;
readonly attribute long clientX;
readonly attribute long clientY;
-#if defined(ENABLE_POINTER_LOCK) && ENABLE_POINTER_LOCK
- readonly attribute long movementX;
- readonly attribute long movementY;
-#endif
+ readonly attribute [Conditional=POINTER_LOCK, EnabledAtRuntime] long webkitMovementX;
+ readonly attribute [Conditional=POINTER_LOCK, EnabledAtRuntime] long webkitMovementY;
readonly attribute boolean ctrlKey;
readonly attribute boolean shiftKey;
readonly attribute boolean altKey;
Modified: trunk/Source/WebCore/dom/MouseRelatedEvent.h (100365 => 100366)
--- trunk/Source/WebCore/dom/MouseRelatedEvent.h 2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/dom/MouseRelatedEvent.h 2011-11-16 00:34:00 UTC (rev 100366)
@@ -40,8 +40,8 @@
int clientX() const { return m_clientLocation.x(); }
int clientY() const { return m_clientLocation.y(); }
#if ENABLE(POINTER_LOCK)
- int movementX() const { return m_movementDelta.x(); }
- int movementY() const { return m_movementDelta.y(); }
+ int webkitMovementX() const { return m_movementDelta.x(); }
+ int webkitMovementY() const { return m_movementDelta.y(); }
#endif
const LayoutPoint& clientLocation() const { return m_clientLocation; }
int layerX();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
