Title: [224256] trunk/Source/WebKit
- Revision
- 224256
- Author
- wenson_hs...@apple.com
- Date
- 2017-10-31 15:41:22 -0700 (Tue, 31 Oct 2017)
Log Message
Followup to r224238: API::Attachment should generate a _WKAttachment ObjC wrapper
https://bugs.webkit.org/show_bug.cgi?id=179080
Reviewed by Tim Horton.
Fixes a failing API test. The new Attachment object type added in r224238 was not actually being handled in
Object::newObject, so a plain WKObject Objective C wrapper was being created; fix this by allocating a new
_WKAttachment object for Type::Attachment.
* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224255 => 224256)
--- trunk/Source/WebKit/ChangeLog 2017-10-31 22:33:27 UTC (rev 224255)
+++ trunk/Source/WebKit/ChangeLog 2017-10-31 22:41:22 UTC (rev 224256)
@@ -1,3 +1,17 @@
+2017-10-31 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Followup to r224238: API::Attachment should generate a _WKAttachment ObjC wrapper
+ https://bugs.webkit.org/show_bug.cgi?id=179080
+
+ Reviewed by Tim Horton.
+
+ Fixes a failing API test. The new Attachment object type added in r224238 was not actually being handled in
+ Object::newObject, so a plain WKObject Objective C wrapper was being created; fix this by allocating a new
+ _WKAttachment object for Type::Attachment.
+
+ * Shared/Cocoa/APIObject.mm:
+ (API::Object::newObject):
+
2017-10-31 Tim Horton <timothy_hor...@apple.com>
Fix up some content filtering feature flags
Modified: trunk/Source/WebKit/Shared/Cocoa/APIObject.mm (224255 => 224256)
--- trunk/Source/WebKit/Shared/Cocoa/APIObject.mm 2017-10-31 22:33:27 UTC (rev 224255)
+++ trunk/Source/WebKit/Shared/Cocoa/APIObject.mm 2017-10-31 22:41:22 UTC (rev 224256)
@@ -68,6 +68,7 @@
#import "WKWebsiteDataRecordInternal.h"
#import "WKWebsiteDataStoreInternal.h"
#import "WKWindowFeaturesInternal.h"
+#import "_WKAttachmentInternal.h"
#import "_WKAutomationSessionInternal.h"
#import "_WKDownloadInternal.h"
#import "_WKExperimentalFeatureInternal.h"
@@ -105,6 +106,10 @@
wrapper = [WKNSArray alloc];
break;
+ case Type::Attachment:
+ wrapper = [_WKAttachment alloc];
+ break;
+
case Type::AuthenticationChallenge:
wrapper = NSAllocateObject([WKNSURLAuthenticationChallenge self], size, nullptr);
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
