Title: [224271] trunk/LayoutTests
- Revision
- 224271
- Author
- [email protected]
- Date
- 2017-10-31 20:26:41 -0700 (Tue, 31 Oct 2017)
Log Message
Fix a couple of service worker tests and unskip them
https://bugs.webkit.org/show_bug.cgi?id=179088
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Merge fixes from https://github.com/w3c/web-platform-tests/pull/8019 and rebaseline tests.
* web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt:
* web-platform-tests/service-workers/service-worker/resources/fetch-event-network-error-controllee-iframe.html:
* web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-argument-iframe.html:
LayoutTests:
Unskip the 2 tests.
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (224270 => 224271)
--- trunk/LayoutTests/ChangeLog 2017-11-01 02:07:20 UTC (rev 224270)
+++ trunk/LayoutTests/ChangeLog 2017-11-01 03:26:41 UTC (rev 224271)
@@ -1,3 +1,14 @@
+2017-10-31 Chris Dumez <[email protected]>
+
+ Fix a couple of service worker tests and unskip them
+ https://bugs.webkit.org/show_bug.cgi?id=179088
+
+ Reviewed by Sam Weinig.
+
+ Unskip the 2 tests.
+
+ * TestExpectations:
+
2017-10-31 Alex Christensen <[email protected]>
Use asynchronous ResourceHandleClient calls for WebKit1
Modified: trunk/LayoutTests/TestExpectations (224270 => 224271)
--- trunk/LayoutTests/TestExpectations 2017-11-01 02:07:20 UTC (rev 224270)
+++ trunk/LayoutTests/TestExpectations 2017-11-01 03:26:41 UTC (rev 224271)
@@ -150,8 +150,6 @@
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ Skip ]
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ Skip ]
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ Skip ]
-imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https.html [ Skip ]
-imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https.html [ Skip ]
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html [ Skip ]
imported/w3c/web-platform-tests/service-workers/service-worker/foreign-fetch-basics.https.html [ Skip ]
imported/w3c/web-platform-tests/service-workers/service-worker/foreign-fetch-event.https.html [ Skip ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (224270 => 224271)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-11-01 02:07:20 UTC (rev 224270)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-11-01 03:26:41 UTC (rev 224271)
@@ -1,3 +1,17 @@
+2017-10-31 Chris Dumez <[email protected]>
+
+ Fix a couple of service worker tests and unskip them
+ https://bugs.webkit.org/show_bug.cgi?id=179088
+
+ Reviewed by Sam Weinig.
+
+ Merge fixes from https://github.com/w3c/web-platform-tests/pull/8019 and rebaseline tests.
+
+ * web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:
+ * web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt:
+ * web-platform-tests/service-workers/service-worker/resources/fetch-event-network-error-controllee-iframe.html:
+ * web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-argument-iframe.html:
+
2017-10-30 Chris Dumez <[email protected]>
Fire updatefound event after resolving the registration promise
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt (224270 => 224271)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt 2017-11-01 02:07:20 UTC (rev 224270)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt 2017-11-01 03:26:41 UTC (rev 224271)
@@ -1,7 +1,3 @@
-CONSOLE MESSAGE: line 57: TypeError: window.parent.notify_done is not a function. (In 'window.parent.notify_done('FAIL: no controller')', 'window.parent.notify_done' is undefined)
+FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller"
-Harness Error (TIMEOUT), message = null
-
-TIMEOUT Rejecting the fetch event or using preventDefault() causes a network error Test timed out
-
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt (224270 => 224271)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt 2017-11-01 02:07:20 UTC (rev 224270)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt 2017-11-01 03:26:41 UTC (rev 224271)
@@ -1,7 +1,3 @@
-CONSOLE MESSAGE: line 52: TypeError: window.parent.notify_done is not a function. (In 'window.parent.notify_done('FAIL: no controller')', 'window.parent.notify_done' is undefined)
+FAIL respondWith() takes either a Response or a promise that resolves with a Response. Other values should raise a network error. assert_equals: expected "PASS" but got "FAIL: no controller"
-Harness Error (TIMEOUT), message = null
-
-TIMEOUT respondWith() takes either a Response or a promise that resolves with a Response. Other values should raise a network error. Test timed out
-
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-event-network-error-controllee-iframe.html (224270 => 224271)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-event-network-error-controllee-iframe.html 2017-11-01 02:07:20 UTC (rev 224270)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-event-network-error-controllee-iframe.html 2017-11-01 03:26:41 UTC (rev 224271)
@@ -54,7 +54,7 @@
}
if (!navigator.serviceWorker.controller)
- window.parent.notify_done('FAIL: no controller');
+ window.parent.notify_test_done('FAIL: no controller');
else
run_tests();
</script>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-argument-iframe.html (224270 => 224271)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-argument-iframe.html 2017-11-01 02:07:20 UTC (rev 224270)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-argument-iframe.html 2017-11-01 03:26:41 UTC (rev 224271)
@@ -49,7 +49,7 @@
}
if (!navigator.serviceWorker.controller)
- window.parent.notify_done('FAIL: no controller');
+ window.parent.notify_test_done('FAIL: no controller');
else
run_tests();
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes