Title: [224278] trunk/Source/WebCore
- Revision
- 224278
- Author
- [email protected]
- Date
- 2017-11-01 08:36:49 -0700 (Wed, 01 Nov 2017)
Log Message
Fix ContinuationChainNode::insertAfter assertion.
https://bugs.webkit.org/show_bug.cgi?id=179115
Patch by Emilio Cobos Álvarez <[email protected]> on 2017-11-01
Reviewed by Antti Koivisto.
The assertion was writing instead of reading next->previous.
Hopefully it's harmless because it was clobbered on the same line, but
it's worth asserting what it was intending to assert.
No new tests (no behaviour change).
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::ContinuationChainNode::insertAfter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (224277 => 224278)
--- trunk/Source/WebCore/ChangeLog 2017-11-01 13:31:36 UTC (rev 224277)
+++ trunk/Source/WebCore/ChangeLog 2017-11-01 15:36:49 UTC (rev 224278)
@@ -1,3 +1,20 @@
+2017-11-01 Emilio Cobos Álvarez <[email protected]>
+
+ Fix ContinuationChainNode::insertAfter assertion.
+ https://bugs.webkit.org/show_bug.cgi?id=179115
+
+ Reviewed by Antti Koivisto.
+
+ The assertion was writing instead of reading next->previous.
+
+ Hopefully it's harmless because it was clobbered on the same line, but
+ it's worth asserting what it was intending to assert.
+
+ No new tests (no behaviour change).
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::ContinuationChainNode::insertAfter):
+
2017-11-01 Fujii Hironori <[email protected]>
Use LazyNeverDestroyed instead of DEFINE_GLOBAL
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (224277 => 224278)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2017-11-01 13:31:36 UTC (rev 224277)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2017-11-01 15:36:49 UTC (rev 224278)
@@ -114,7 +114,7 @@
ASSERT(!previous);
ASSERT(!next);
if ((next = after.next)) {
- ASSERT(next->previous = &after);
+ ASSERT(next->previous == &after);
next->previous = this;
}
previous = &after;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
