Title: [224332] trunk/Source/WebCore
- Revision
- 224332
- Author
- [email protected]
- Date
- 2017-11-02 08:57:49 -0700 (Thu, 02 Nov 2017)
Log Message
Remove empty continuations in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers
https://bugs.webkit.org/show_bug.cgi?id=179014
Remove overly optimistic non-critical assertion that is hit on WK1 debug.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (224331 => 224332)
--- trunk/Source/WebCore/ChangeLog 2017-11-02 14:48:07 UTC (rev 224331)
+++ trunk/Source/WebCore/ChangeLog 2017-11-02 15:57:49 UTC (rev 224332)
@@ -1,3 +1,13 @@
+2017-11-02 Antti Koivisto <[email protected]>
+
+ Remove empty continuations in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers
+ https://bugs.webkit.org/show_bug.cgi?id=179014
+
+ Remove overly optimistic non-critical assertion that is hit on WK1 debug.
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations):
+
2017-11-02 Frederic Wang <[email protected]>
Add references to bug 179167 in FIXME comments
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (224331 => 224332)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2017-11-02 14:48:07 UTC (rev 224331)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2017-11-02 15:57:49 UTC (rev 224332)
@@ -2535,10 +2535,8 @@
ASSERT(hasContinuationChainNode());
ASSERT(continuationChainNodeMap().contains(this));
auto& continuationChainNode = *continuationChainNodeMap().get(this);
- while (continuationChainNode.next) {
- ASSERT(!continuationChainNode.next->renderer->firstChild());
+ while (continuationChainNode.next)
continuationChainNode.next->renderer->removeFromParentAndDestroy();
- }
removeFromContinuationChain();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
