Title: [224346] trunk/Source/WebKit
- Revision
- 224346
- Author
- [email protected]
- Date
- 2017-11-02 11:27:13 -0700 (Thu, 02 Nov 2017)
Log Message
Early out selection update when data is not present
https://bugs.webkit.org/show_bug.cgi?id=179084
Reviewed by Ryosuke Niwa.
We should early out of a selection update when we do not have the data that is necessary to make that
update. This mostly helps avoid debug asserts, but will be helpful with the selection changes that are
ongoing.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _updateChangedSelection:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224345 => 224346)
--- trunk/Source/WebKit/ChangeLog 2017-11-02 18:25:28 UTC (rev 224345)
+++ trunk/Source/WebKit/ChangeLog 2017-11-02 18:27:13 UTC (rev 224346)
@@ -1,3 +1,17 @@
+2017-11-02 Megan Gardner <[email protected]>
+
+ Early out selection update when data is not present
+ https://bugs.webkit.org/show_bug.cgi?id=179084
+
+ Reviewed by Ryosuke Niwa.
+
+ We should early out of a selection update when we do not have the data that is necessary to make that
+ update. This mostly helps avoid debug asserts, but will be helpful with the selection changes that are
+ ongoing.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _updateChangedSelection:]):
+
2017-11-02 Eric Carlson <[email protected]>
[MediaStream] audioTrack.label is always empty on macOS
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (224345 => 224346)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-11-02 18:25:28 UTC (rev 224345)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-11-02 18:27:13 UTC (rev 224346)
@@ -3957,7 +3957,7 @@
- (void)_updateChangedSelection:(BOOL)force
{
- if (!_selectionNeedsUpdate)
+ if (!_selectionNeedsUpdate || _page->editorState().isMissingPostLayoutData)
return;
WKSelectionDrawingInfo selectionDrawingInfo(_page->editorState());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
