Title: [224391] trunk/Source/WebInspectorUI
- Revision
- 224391
- Author
- [email protected]
- Date
- 2017-11-03 03:00:23 -0700 (Fri, 03 Nov 2017)
Log Message
Web Inspector: Network Table - Include a secure lock indicator in the domain column
https://bugs.webkit.org/show_bug.cgi?id=179233
<rdar://problem/34070883>
Patch by Joseph Pecoraro <[email protected]> on 2017-11-03
Reviewed by Devin Rousso.
* UserInterface/Views/NetworkTableContentView.css:
(.network-table .cell.domain > .lock):
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.tablePopulateCell):
(WI.NetworkTableContentView.prototype._populateDomainCell):
Add a small lock icon by the domain if the request was https/wss.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (224390 => 224391)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-11-03 09:32:05 UTC (rev 224390)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-11-03 10:00:23 UTC (rev 224391)
@@ -1,3 +1,18 @@
+2017-11-03 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Network Table - Include a secure lock indicator in the domain column
+ https://bugs.webkit.org/show_bug.cgi?id=179233
+ <rdar://problem/34070883>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/NetworkTableContentView.css:
+ (.network-table .cell.domain > .lock):
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype.tablePopulateCell):
+ (WI.NetworkTableContentView.prototype._populateDomainCell):
+ Add a small lock icon by the domain if the request was https/wss.
+
2017-11-03 Devin Rousso <[email protected]>
Web Inspector: Canvas2D Profiling: highlight expensive context commands in the captured command log
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css (224390 => 224391)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2017-11-03 09:32:05 UTC (rev 224390)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css 2017-11-03 10:00:23 UTC (rev 224391)
@@ -48,6 +48,13 @@
color: var(--error-text-color);
}
+.network-table .cell.domain > .lock {
+ width: 8px;
+ height: 10px;
+ content: url(../Images/Locked.svg);
+ -webkit-margin-end: 5px;
+}
+
body[dir=ltr] .network-table .cell.name > .status {
float: right;
margin-left: 4px;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (224390 => 224391)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-11-03 09:32:05 UTC (rev 224390)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-11-03 10:00:23 UTC (rev 224391)
@@ -338,7 +338,7 @@
this._populateNameCell(cell, entry);
break;
case "domain":
- cell.textContent = entry.domain || emDash;
+ this._populateDomainCell(cell, entry);
break;
case "type":
cell.textContent = entry.displayType || emDash;
@@ -407,6 +407,24 @@
nameElement.textContent = entry.name;
}
+ _populateDomainCell(cell, entry)
+ {
+ console.assert(!cell.firstChild, "We expect the cell to be empty.", cell, cell.firstChild);
+
+ if (!entry.domain) {
+ cell.textContent = emDash;
+ return;
+ }
+
+ let secure = entry.scheme === "https" || entry.scheme === "wss";
+ if (secure) {
+ let lockIconElement = cell.appendChild(document.createElement("img"));
+ lockIconElement.className = "lock";
+ }
+
+ cell.append(entry.domain);
+ }
+
_populateTransferSizeCell(cell, entry)
{
let responseSource = entry.resource.responseSource;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
