Title: [224406] trunk/Source/WebKit
- Revision
- 224406
- Author
- commit-qu...@webkit.org
- Date
- 2017-11-03 11:03:51 -0700 (Fri, 03 Nov 2017)
Log Message
Element fullscreen should use FloatRects instead of IntRects in beganEnterFullScreenWithInitialFrame
https://bugs.webkit.org/show_bug.cgi?id=179033
rdar://problem/35309279
Patch by Jeremy Jones <jere...@apple.com> on 2017-11-03
Reviewed by Darin Adler.
Screen coordinates are floats, so use NSRect instead of IntRect on Mac.
* UIProcess/mac/WKFullScreenWindowController.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (224405 => 224406)
--- trunk/Source/WebKit/ChangeLog 2017-11-03 17:10:42 UTC (rev 224405)
+++ trunk/Source/WebKit/ChangeLog 2017-11-03 18:03:51 UTC (rev 224406)
@@ -1,3 +1,18 @@
+2017-11-03 Jeremy Jones <jere...@apple.com>
+
+ Element fullscreen should use FloatRects instead of IntRects in beganEnterFullScreenWithInitialFrame
+ https://bugs.webkit.org/show_bug.cgi?id=179033
+ rdar://problem/35309279
+
+ Reviewed by Darin Adler.
+
+ Screen coordinates are floats, so use NSRect instead of IntRect on Mac.
+
+ * UIProcess/mac/WKFullScreenWindowController.h:
+ * UIProcess/mac/WKFullScreenWindowController.mm:
+ (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
+ (-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
+
2017-11-03 Chris Dumez <cdu...@apple.com>
Use a single identifier type to identify Service Workers
Modified: trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.h (224405 => 224406)
--- trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.h 2017-11-03 17:10:42 UTC (rev 224405)
+++ trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.h 2017-11-03 18:03:51 UTC (rev 224406)
@@ -75,8 +75,8 @@
- (void)exitFullScreen;
- (void)requestExitFullScreen;
- (void)close;
-- (void)beganEnterFullScreenWithInitialFrame:(const WebCore::IntRect&)initialFrame finalFrame:(const WebCore::IntRect&)finalFrame;
-- (void)beganExitFullScreenWithInitialFrame:(const WebCore::IntRect&)initialFrame finalFrame:(const WebCore::IntRect&)finalFrame;
+- (void)beganEnterFullScreenWithInitialFrame:(NSRect)initialFrame finalFrame:(NSRect)finalFrame;
+- (void)beganExitFullScreenWithInitialFrame:(NSRect)initialFrame finalFrame:(NSRect)finalFrame;
@end
Modified: trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm (224405 => 224406)
--- trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm 2017-11-03 17:10:42 UTC (rev 224405)
+++ trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm 2017-11-03 18:03:51 UTC (rev 224406)
@@ -261,7 +261,7 @@
[self _manager]->willEnterFullScreen();
}
-- (void)beganEnterFullScreenWithInitialFrame:(const WebCore::IntRect&)initialFrame finalFrame:(const WebCore::IntRect&)finalFrame
+- (void)beganEnterFullScreenWithInitialFrame:(NSRect)initialFrame finalFrame:(NSRect)finalFrame
{
if (_fullScreenState != WaitingToEnterFullScreen)
return;
@@ -356,7 +356,7 @@
[self _manager]->requestExitFullScreen();
}
-- (void)beganExitFullScreenWithInitialFrame:(const WebCore::IntRect&)initialFrame finalFrame:(const WebCore::IntRect&)finalFrame
+- (void)beganExitFullScreenWithInitialFrame:(NSRect)initialFrame finalFrame:(NSRect)finalFrame
{
if (_fullScreenState != WaitingToExitFullScreen)
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
