Title: [224432] trunk/LayoutTests
- Revision
- 224432
- Author
- achristen...@apple.com
- Date
- 2017-11-03 14:30:08 -0700 (Fri, 03 Nov 2017)
Log Message
LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2
https://bugs.webkit.org/show_bug.cgi?id=159884
Reviewed by Darin Adler.
* http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
* http/tests/loading/basic-auth-resend-wrong-credentials.html:
* platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (224431 => 224432)
--- trunk/LayoutTests/ChangeLog 2017-11-03 21:26:59 UTC (rev 224431)
+++ trunk/LayoutTests/ChangeLog 2017-11-03 21:30:08 UTC (rev 224432)
@@ -1,3 +1,14 @@
+2017-11-03 Alex Christensen <achristen...@webkit.org>
+
+ LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2
+ https://bugs.webkit.org/show_bug.cgi?id=159884
+
+ Reviewed by Darin Adler.
+
+ * http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+ * http/tests/loading/basic-auth-resend-wrong-credentials.html:
+ * platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+
2017-11-03 Ryan Haddad <ryanhad...@apple.com>
Mark http/tests/security/mixedContent/insecure-css-with-secure-cookies.html as flaky.
Modified: trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt (224431 => 224432)
--- trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-11-03 21:26:59 UTC (rev 224431)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-11-03 21:30:08 UTC (rev 224432)
@@ -7,12 +7,14 @@
http://127.0.0.1:8000/loading/resources/test2/protected-resource.php - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
+frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
+frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
Modified: trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html (224431 => 224432)
--- trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html 2017-11-03 21:26:59 UTC (rev 224431)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html 2017-11-03 21:30:08 UTC (rev 224432)
@@ -12,14 +12,16 @@
}
function firstFrameLoaded() {
- if (window.testRunner) {
- testRunner.setAuthenticationUsername("correctusername");
- testRunner.setAuthenticationPassword("correctpassword");
- }
- var frame = document.createElement("iframe");
- frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword");
- frame.setAttribute("onload", "secondFrameLoaded()");
- document.body.appendChild(frame);
+ setTimeout(()=>{
+ if (window.testRunner) {
+ testRunner.setAuthenticationUsername("correctusername");
+ testRunner.setAuthenticationPassword("correctpassword");
+ }
+ var frame = document.createElement("iframe");
+ frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword");
+ frame.setAttribute("onload", "secondFrameLoaded()");
+ document.body.appendChild(frame);
+ }, 0);
}
function secondFrameLoaded() {
Modified: trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt (224431 => 224432)
--- trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-11-03 21:26:59 UTC (rev 224431)
+++ trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-11-03 21:30:08 UTC (rev 224432)
@@ -7,12 +7,14 @@
127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
+frame "<!--framePath //<!--frame1-->-->" - didStartProvisionalLoadForFrame
127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
+frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
+frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
