Title: [100385] trunk/Source/_javascript_Core
- Revision
- 100385
- Author
- [email protected]
- Date
- 2011-11-15 17:53:29 -0800 (Tue, 15 Nov 2011)
Log Message
Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.
Reviewed by Sam Weinig.
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.
* runtime/ArgList.h: Removed!
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100384 => 100385)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 01:53:29 UTC (rev 100385)
@@ -1,5 +1,19 @@
2011-11-15 Geoffrey Garen <[email protected]>
+ Removed another use of ArgList that baked in the assumption that arguments
+ are forward in the regiter file.
+
+ Reviewed by Sam Weinig.
+
+ * dfg/DFGOperations.cpp:
+ * jit/JITStubs.cpp:
+ (JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
+ working through ArgList.
+
+ * runtime/ArgList.h: Removed!
+
+2011-11-15 Geoffrey Garen <[email protected]>
+
Removed a use of ArgList that baked in the assumption that arguments
are forward in the regiter file.
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (100384 => 100385)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-11-16 01:53:29 UTC (rev 100385)
@@ -773,8 +773,7 @@
EncodedJSValue DFG_OPERATION operationNewArray(ExecState* exec, void* start, size_t size)
{
- ArgList argList(static_cast<Register*>(start), size);
- return JSValue::encode(constructArray(exec, argList));
+ return JSValue::encode(constructArray(exec, static_cast<JSValue*>(start), size));
}
EncodedJSValue DFG_OPERATION operationNewArrayBuffer(ExecState* exec, size_t start, size_t size)
Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (100384 => 100385)
--- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-11-16 01:53:29 UTC (rev 100385)
@@ -2432,8 +2432,7 @@
{
STUB_INIT_STACK_FRAME(stackFrame);
- ArgList argList(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()], stackFrame.args[1].int32());
- return constructArray(stackFrame.callFrame, argList);
+ return constructArray(stackFrame.callFrame, reinterpret_cast<JSValue*>(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()]), stackFrame.args[1].int32());
}
DEFINE_STUB_FUNCTION(JSObject*, op_new_array_buffer)
Modified: trunk/Source/_javascript_Core/runtime/ArgList.h (100384 => 100385)
--- trunk/Source/_javascript_Core/runtime/ArgList.h 2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/runtime/ArgList.h 2011-11-16 01:53:29 UTC (rev 100385)
@@ -191,13 +191,6 @@
{
}
- ArgList(Register* args, int argCount)
- : m_args(reinterpret_cast<JSValue*>(args))
- , m_argCount(argCount)
- {
- ASSERT(argCount >= 0);
- }
-
ArgList(const MarkedArgumentBuffer& args)
: m_args(reinterpret_cast<JSValue*>(const_cast<Register*>(args.begin())))
, m_argCount(args.size())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
