Title: [224458] trunk/Tools
- Revision
- 224458
- Author
- [email protected]
- Date
- 2017-11-04 09:47:46 -0700 (Sat, 04 Nov 2017)
Log Message
[GTK] Fix gtk-doc generation with gtk-doc master
https://bugs.webkit.org/show_bug.cgi?id=179252
Reviewed by Carlos Garcia Campos.
gtkdoc-scangobj has changed to no longer use a shell when executing its subcommands. In
particular, this means we can no longer rely on shell stuff in our run command that we use
to run the scanner. We currently use the RUN envvar to set LD_LIBRARY_PATH, and the end
result is gtkdoc-scangobj now attempts to execute our environment variable instead of the
scanner itself. We can just set LD_LIBRARY_PATH directly, instead of using RUN, in order to
make documentation generation work again.
* gtk/gtkdoc.py:
(GTKDoc._run_gtkdoc_scangobj):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (224457 => 224458)
--- trunk/Tools/ChangeLog 2017-11-04 08:20:03 UTC (rev 224457)
+++ trunk/Tools/ChangeLog 2017-11-04 16:47:46 UTC (rev 224458)
@@ -1,3 +1,20 @@
+2017-11-04 Michael Catanzaro <[email protected]>
+
+ [GTK] Fix gtk-doc generation with gtk-doc master
+ https://bugs.webkit.org/show_bug.cgi?id=179252
+
+ Reviewed by Carlos Garcia Campos.
+
+ gtkdoc-scangobj has changed to no longer use a shell when executing its subcommands. In
+ particular, this means we can no longer rely on shell stuff in our run command that we use
+ to run the scanner. We currently use the RUN envvar to set LD_LIBRARY_PATH, and the end
+ result is gtkdoc-scangobj now attempts to execute our environment variable instead of the
+ scanner itself. We can just set LD_LIBRARY_PATH directly, instead of using RUN, in order to
+ make documentation generation work again.
+
+ * gtk/gtkdoc.py:
+ (GTKDoc._run_gtkdoc_scangobj):
+
2017-11-04 Aishwarya Nirmal <[email protected]>
[Touch Bar Web API] Add support for menuitem tag
Modified: trunk/Tools/gtk/gtkdoc.py (224457 => 224458)
--- trunk/Tools/gtk/gtkdoc.py 2017-11-04 08:20:03 UTC (rev 224457)
+++ trunk/Tools/gtk/gtkdoc.py 2017-11-04 16:47:46 UTC (rev 224458)
@@ -319,9 +319,9 @@
ldflags = ' "-L%s" %s ' % (self.library_path, additional_ldflags) + ldflags
current_ld_library_path = env.get('LD_LIBRARY_PATH')
if current_ld_library_path:
- env['RUN'] = 'LD_LIBRARY_PATH="%s:%s" ' % (self.library_path, current_ld_library_path)
+ env['LD_LIBRARY_PATH'] = '%s:%s' % (self.library_path, current_ld_library_path)
else:
- env['RUN'] = 'LD_LIBRARY_PATH="%s" ' % self.library_path
+ env['LD_LIBRARY_PATH'] = self.library_path
if ldflags:
env['LDFLAGS'] = '%s %s' % (ldflags, env.get('LDFLAGS', ''))
@@ -332,8 +332,6 @@
self.logger.debug('CFLAGS=%s', env['CFLAGS'])
if 'LDFLAGS' in env:
self.logger.debug('LDFLAGS %s', env['LDFLAGS'])
- if 'RUN' in env:
- self.logger.debug('RUN=%s', env['RUN'])
self._run_command(['gtkdoc-scangobj', '--module=%s' % self.module_name],
env=env, cwd=self.output_dir)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
