Title: [224491] trunk/Source/_javascript_Core
- Revision
- 224491
- Author
- rmoris...@apple.com
- Date
- 2017-11-06 06:55:31 -0800 (Mon, 06 Nov 2017)
Log Message
CodeBlock::usesOpcode() is dead code
https://bugs.webkit.org/show_bug.cgi?id=179316
Reviewed by Yusuke Suzuki.
Remove CodeBlock::usesOpcode which is dead code
* bytecode/CodeBlock.cpp:
* bytecode/CodeBlock.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (224490 => 224491)
--- trunk/Source/_javascript_Core/ChangeLog 2017-11-06 14:43:36 UTC (rev 224490)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-11-06 14:55:31 UTC (rev 224491)
@@ -1,3 +1,15 @@
+2017-11-06 Robin Morisset <rmoris...@apple.com>
+
+ CodeBlock::usesOpcode() is dead code
+ https://bugs.webkit.org/show_bug.cgi?id=179316
+
+ Reviewed by Yusuke Suzuki.
+
+ Remove CodeBlock::usesOpcode which is dead code
+
+ * bytecode/CodeBlock.cpp:
+ * bytecode/CodeBlock.h:
+
2017-11-05 Yusuke Suzuki <utatane....@gmail.com>
JIT call inline caches should cache calls to objects with getCallData/getConstructData traps
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (224490 => 224491)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2017-11-06 14:43:36 UTC (rev 224490)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2017-11-06 14:55:31 UTC (rev 224491)
@@ -2800,30 +2800,6 @@
return static_cast<size_t>(doubleResult);
}
-bool CodeBlock::usesOpcode(OpcodeID opcodeID)
-{
- Instruction* instructionsBegin = instructions().begin();
- unsigned instructionCount = instructions().size();
-
- for (unsigned bytecodeOffset = 0; bytecodeOffset < instructionCount; ) {
- switch (Interpreter::getOpcodeID(instructionsBegin[bytecodeOffset])) {
-#define DEFINE_OP(curOpcode, length) \
- case curOpcode: \
- if (curOpcode == opcodeID) \
- return true; \
- bytecodeOffset += length; \
- break;
- FOR_EACH_OPCODE_ID(DEFINE_OP)
-#undef DEFINE_OP
- default:
- RELEASE_ASSERT_NOT_REACHED();
- break;
- }
- }
-
- return false;
-}
-
String CodeBlock::nameForRegister(VirtualRegister virtualRegister)
{
for (auto& constantRegister : m_constantRegisters) {
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (224490 => 224491)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2017-11-06 14:43:36 UTC (rev 224490)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2017-11-06 14:55:31 UTC (rev 224491)
@@ -316,8 +316,6 @@
size_t predictedMachineCodeSize();
- bool usesOpcode(OpcodeID);
-
unsigned instructionCount() const { return m_instructions.size(); }
// Exactly equivalent to codeBlock->ownerExecutable()->newReplacementCodeBlockFor(codeBlock->specializationKind())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
