Title: [224520] trunk/Source/WebInspectorUI
- Revision
- 224520
- Author
- [email protected]
- Date
- 2017-11-06 16:52:47 -0800 (Mon, 06 Nov 2017)
Log Message
Web Inspector: Two little Layers tab fixes
https://bugs.webkit.org/show_bug.cgi?id=179273
Reviewed by Devin Rousso.
* UserInterface/Views/LayerDetailsSidebarPanel.js:
(WI.LayerDetailsSidebarPanel.prototype.selectNodeByLayerId):
Even when we suppress refire of the selected event, we still want a popover.
* UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.shown):
(WI.Layers3DContentView.prototype.hidden):
(WI.Layers3DContentView.prototype.closed):
(WI.Layers3DContentView.prototype._layerTreeDidChange):
Opening WI directly to the Layers tab wasn't fetching layers right away. Let's fetch on every shown() and
prune the hacky logic we were previously using -- it's overkill anyway, now that we're tracking mutations.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (224519 => 224520)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-11-07 00:49:08 UTC (rev 224519)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-11-07 00:52:47 UTC (rev 224520)
@@ -1,3 +1,23 @@
+2017-11-06 Ross Kirsling <[email protected]>
+
+ Web Inspector: Two little Layers tab fixes
+ https://bugs.webkit.org/show_bug.cgi?id=179273
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/LayerDetailsSidebarPanel.js:
+ (WI.LayerDetailsSidebarPanel.prototype.selectNodeByLayerId):
+ Even when we suppress refire of the selected event, we still want a popover.
+
+ * UserInterface/Views/Layers3DContentView.js:
+ (WI.Layers3DContentView):
+ (WI.Layers3DContentView.prototype.shown):
+ (WI.Layers3DContentView.prototype.hidden):
+ (WI.Layers3DContentView.prototype.closed):
+ (WI.Layers3DContentView.prototype._layerTreeDidChange):
+ Opening WI directly to the Layers tab wasn't fetching layers right away. Let's fetch on every shown() and
+ prune the hacky logic we were previously using -- it's overkill anyway, now that we're tracking mutations.
+
2017-11-06 Joseph Pecoraro <[email protected]>
Web Inspector: no way to navigate from Resource tree element to its entry in Network Tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js (224519 => 224520)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js 2017-11-07 00:49:08 UTC (rev 224519)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js 2017-11-07 00:52:47 UTC (rev 224520)
@@ -68,9 +68,10 @@
return;
const suppressEvent = true;
- if (node)
+ if (node) {
node.revealAndSelect(suppressEvent);
- else if (this._dataGrid.selectedNode)
+ this._showPopoverForSelectedNode();
+ } else if (this._dataGrid.selectedNode)
this._dataGrid.selectedNode.deselect(suppressEvent);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js (224519 => 224520)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js 2017-11-07 00:49:08 UTC (rev 224519)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js 2017-11-07 00:52:47 UTC (rev 224520)
@@ -42,12 +42,9 @@
this._paintFlashingButtonNavigationItem.activated = PageAgent.setShowPaintRects && WI.showPaintRectsSetting.value;
this._paintFlashingButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
- WI.layerTreeManager.addEventListener(WI.LayerTreeManager.Event.LayerTreeDidChange, this._layerTreeDidChange, this);
-
this._layers = [];
this._layerGroupsById = new Map;
this._selectedLayerGroup = null;
- this._layersChangedWhileHidden = false;
this._renderer = null;
this._camera = null;
@@ -78,12 +75,9 @@
this._updateCompositingBordersButtonState();
- if (this._layersChangedWhileHidden) {
- this._layersChangedWhileHidden = false;
-
- this.updateLayout();
- }
-
+ this.updateLayout();
+ WI.layerTreeManager.addEventListener(WI.LayerTreeManager.Event.LayerTreeDidChange, this._layerTreeDidChange, this);
+
if (this.didInitialLayout)
this._animate();
}
@@ -90,6 +84,7 @@
hidden()
{
+ WI.layerTreeManager.removeEventListener(WI.LayerTreeManager.Event.LayerTreeDidChange, this._layerTreeDidChange, this);
this._stopAnimation();
super.hidden();
@@ -98,7 +93,6 @@
closed()
{
WI.showPaintRectsSetting.removeEventListener(WI.Setting.Event.Changed, this._showPaintRectsSettingChanged, this);
- WI.layerTreeManager.removeEventListener(WI.LayerTreeManager.Event.LayerTreeDidChange, this._layerTreeDidChange, this);
super.closed();
}
@@ -175,11 +169,6 @@
_layerTreeDidChange(event)
{
- if (!this.visible) {
- this._layersChangedWhileHidden = true;
- return;
- }
-
this.needsLayout();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
